node: allow preload modules with -i #4696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mscdex
added
the
lib / src
jasnell
added
the
semver-minor
|
I think there was an issue for this. Will take a look tomorrow. |
|
fixes: #4661 |
| @@ -0,0 +1,5 @@ | |||
| global.a = 'test'; | |||
| process.stdin.on('data', function(chunk) { | |||
There was a problem hiding this comment.
I just ran this locally without this block of code and it still passed. Are you sure this is needed?
There was a problem hiding this comment.
Strange, it wasn't working for me. The process never ended until I added this. I'll take another look though
There was a problem hiding this comment.
Yep, you were right. Not sure why I was getting that issue. Updated
|
LGTM with a few comments. |
|
Updated to fix requested changes. PTAL |
|
LGTM. There were Jenkins issues in the last run. Trying the CI again: https://ci.nodejs.org/job/node-test-pull-request/1291/ |
|
Buildbot failure in CI, otherwise green. LGTM |
This gives us the ability to preload when using the node repl. This can be useful for doing things like creating aliases. Fixes: nodejs#4661 PR-URL: nodejs#4696 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
|
Landed in ff64a4c. Thanks! |
evanlucas
added a commit
that referenced
this pull request
Jan 18, 2016
This gives us the ability to preload when using the node repl. This can be useful for doing things like creating aliases. Fixes: #4661 PR-URL: #4696 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
evanlucas
added a commit
that referenced
this pull request
Jan 20, 2016
Notable changes: * events: make sure console functions exist (Dave) #4479 * fs: add autoClose option to fs.createWriteStream (Saquib) #3679 * http: improves expect header handling (Daniel Sellers) #4501 * node: allow preload modules with -i (Evan Lucas) #4696 * v8,src: expose statistics about heap spaces (`v8.getHeapSpaceStatistics()`) (Ben Ripkens) #4463 * Minor performance improvements: - lib: Use arrow functions instead of bind where possible (Minwoo Jung) #3622 - module: cache stat() results more aggressively (Ben Noordhuis) #4575 - querystring: improve parse() performance (Brian White) #4675 PR-URL: #4742
evanlucas
added a commit
that referenced
this pull request
Jan 21, 2016
Notable changes: * events: make sure console functions exist (Dave) #4479 * fs: add autoClose option to fs.createWriteStream (Saquib) #3679 * http: improves expect header handling (Daniel Sellers) #4501 * node: allow preload modules with -i (Evan Lucas) #4696 * v8,src: expose statistics about heap spaces (`v8.getHeapSpaceStatistics()`) (Ben Ripkens) #4463 * Minor performance improvements: - lib: Use arrow functions instead of bind where possible (Minwoo Jung) #3622 - module: cache stat() results more aggressively (Ben Noordhuis) #4575 - querystring: improve parse() performance (Brian White) #4675 PR-URL: #4742
scovetta
pushed a commit
to scovetta/node
that referenced
this pull request
Apr 2, 2016
This gives us the ability to preload when using the node repl. This can be useful for doing things like creating aliases. Fixes: nodejs#4661 PR-URL: nodejs#4696 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
scovetta
pushed a commit
to scovetta/node
that referenced
this pull request
Apr 2, 2016
Notable changes: * events: make sure console functions exist (Dave) nodejs#4479 * fs: add autoClose option to fs.createWriteStream (Saquib) nodejs#3679 * http: improves expect header handling (Daniel Sellers) nodejs#4501 * node: allow preload modules with -i (Evan Lucas) nodejs#4696 * v8,src: expose statistics about heap spaces (`v8.getHeapSpaceStatistics()`) (Ben Ripkens) nodejs#4463 * Minor performance improvements: - lib: Use arrow functions instead of bind where possible (Minwoo Jung) nodejs#3622 - module: cache stat() results more aggressively (Ben Noordhuis) nodejs#4575 - querystring: improve parse() performance (Brian White) nodejs#4675 PR-URL: nodejs#4742
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gives us the ability to preload when using the node repl. This can
be useful for doing things like creating aliases.