doc: remove useless SSL_OP_* options #46954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These 14 options do not have any effect in any supported version of OpenSSL.
tniessen
added a commit
to tniessen/node
that referenced
this pull request
Mar 4, 2023
This option does not have any effect in any supported OpenSSL version. Refs: nodejs#46954
bnoordhuis
approved these changes
Mar 5, 2023
panva
approved these changes
Mar 5, 2023
panva
added
author ready
cjihrig
approved these changes
Mar 5, 2023
lpinca
approved these changes
Mar 5, 2023
aymen94
approved these changes
Mar 6, 2023
nodejs-github-bot
removed
the
commit-queue
|
Landed in db81af6 |
tniessen
added a commit
to tniessen/openssl
that referenced
this pull request
Mar 6, 2023
SSL_OP_NETSCAPE_CA_DN_BUG became obsolete in 3c33c6f and support for SSL_OP_NETSCAPE_DEMO_CIPHER_CHANGE_BUG was removed by 7a4dadc. The definitions are still listed under "OBSOLETE OPTIONS retained for compatibility" in ssl.h.in, so this commit adds them to the list of obsolete options in doc/man3. Refs: nodejs/node#46954
1 task
tniessen
added a commit
that referenced
this pull request
Mar 9, 2023
This option does not have any effect in any supported OpenSSL version. Refs: #46954 PR-URL: #46955 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
targos
pushed a commit
that referenced
this pull request
Mar 13, 2023
These 14 options do not have any effect in any supported version of OpenSSL. PR-URL: #46954 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
targos
pushed a commit
that referenced
this pull request
Mar 13, 2023
This option does not have any effect in any supported OpenSSL version. Refs: #46954 PR-URL: #46955 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
tniessen
added a commit
to tniessen/node
that referenced
this pull request
Mar 13, 2023
I missed these two in db81af6 because I went by OpenSSL's list of obsolete flags, which turned out to be incomplete. See openssl/openssl#20443. Refs: nodejs#46954 Refs: openssl/openssl#20443
nodejs-github-bot
pushed a commit
that referenced
this pull request
Mar 13, 2023
I missed these two in db81af6 because I went by OpenSSL's list of obsolete flags, which turned out to be incomplete. See openssl/openssl#20443. Refs: #46954 Refs: openssl/openssl#20443 PR-URL: #47066 Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
tniessen
added a commit
to tniessen/node
that referenced
this pull request
Mar 13, 2023
None of these constants have any effect in recent OpenSSL versions, not even in Node.js release lines that still use OpenSSL 1.1.1. It is likely rare that these options are still used (intentionally), and removing them is unlikely to break any existing applications. These constants can only be passed to the secureOptions option of tls.createSecureContext() and related APIs, and a value of undefined will be ignored. Similarly, if a bitwise combination of multiple options is used, undefined constants will not change the behavior because (a | undefined | b) === a | b for (small non-negative) integers a and b. Refs: nodejs#46954 Refs: nodejs#47066
tniessen
added a commit
to tniessen/node
that referenced
this pull request
Mar 13, 2023
None of these constants have any effect in recent OpenSSL versions, not even in Node.js release lines that still use OpenSSL 1.1.1. It is likely rare that these options are still used (intentionally), and removing them is unlikely to break any existing applications. These constants can only be passed to the secureOptions option of tls.createSecureContext() and related APIs, and a value of undefined will be ignored. Similarly, if a bitwise combination of multiple options is used, undefined constants will not change the behavior because (a | undefined | b) === (a | b) for (small) integers a and b. Refs: nodejs#46954 Refs: nodejs#47066
targos
pushed a commit
that referenced
this pull request
Mar 14, 2023
These 14 options do not have any effect in any supported version of OpenSSL. PR-URL: #46954 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
targos
pushed a commit
that referenced
this pull request
Mar 14, 2023
This option does not have any effect in any supported OpenSSL version. Refs: #46954 PR-URL: #46955 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
targos
pushed a commit
that referenced
this pull request
Mar 14, 2023
I missed these two in db81af6 because I went by OpenSSL's list of obsolete flags, which turned out to be incomplete. See openssl/openssl#20443. Refs: #46954 Refs: openssl/openssl#20443 PR-URL: #47066 Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
openssl-machine
pushed a commit
to openssl/openssl
that referenced
this pull request
Mar 14, 2023
SSL_OP_NETSCAPE_CA_DN_BUG became obsolete in 3c33c6f and support for SSL_OP_NETSCAPE_DEMO_CIPHER_CHANGE_BUG was removed by 7a4dadc. The definitions are still listed under "OBSOLETE OPTIONS retained for compatibility" in ssl.h.in, so this commit adds them to the list of obsolete options in doc/man3. Refs: nodejs/node#46954 Reviewed-by: Matt Caswell <[email protected]> Reviewed-by: Paul Dale <[email protected]> (Merged from #20443)
openssl-machine
pushed a commit
to openssl/openssl
that referenced
this pull request
Mar 14, 2023
SSL_OP_NETSCAPE_CA_DN_BUG became obsolete in 3c33c6f and support for SSL_OP_NETSCAPE_DEMO_CIPHER_CHANGE_BUG was removed by 7a4dadc. The definitions are still listed under "OBSOLETE OPTIONS retained for compatibility" in ssl.h.in, so this commit adds them to the list of obsolete options in doc/man3. Refs: nodejs/node#46954 Reviewed-by: Matt Caswell <[email protected]> Reviewed-by: Paul Dale <[email protected]> (Merged from #20443) (cherry picked from commit fe52208)
openssl-machine
pushed a commit
to openssl/openssl
that referenced
this pull request
Mar 14, 2023
SSL_OP_NETSCAPE_CA_DN_BUG became obsolete in 3c33c6f and support for SSL_OP_NETSCAPE_DEMO_CIPHER_CHANGE_BUG was removed by 7a4dadc. The definitions are still listed under "OBSOLETE OPTIONS retained for compatibility" in ssl.h.in, so this commit adds them to the list of obsolete options in doc/man3. Refs: nodejs/node#46954 Reviewed-by: Matt Caswell <[email protected]> Reviewed-by: Paul Dale <[email protected]> (Merged from #20443) (cherry picked from commit fe52208)
nodejs-github-bot
pushed a commit
that referenced
this pull request
Mar 21, 2023
None of these constants have any effect in recent OpenSSL versions, not even in Node.js release lines that still use OpenSSL 1.1.1. It is likely rare that these options are still used (intentionally), and removing them is unlikely to break any existing applications. These constants can only be passed to the secureOptions option of tls.createSecureContext() and related APIs, and a value of undefined will be ignored. Similarly, if a bitwise combination of multiple options is used, undefined constants will not change the behavior because (a | undefined | b) === (a | b) for (small) integers a and b. Refs: #46954 Refs: #47066 PR-URL: #47073 Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Apr 11, 2023
These 14 options do not have any effect in any supported version of OpenSSL. PR-URL: #46954 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Apr 11, 2023
This option does not have any effect in any supported OpenSSL version. Refs: #46954 PR-URL: #46955 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Apr 11, 2023
I missed these two in db81af6 because I went by OpenSSL's list of obsolete flags, which turned out to be incomplete. See openssl/openssl#20443. Refs: #46954 Refs: openssl/openssl#20443 PR-URL: #47066 Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These 14 options do not have any effect in any supported version of OpenSSL.