inspector: fix inspector open when there are sessions #46950
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix
inspector.open
when there are sessions.this code above will throw an error ERR_INSPECTOR_ALREADY_ACTIVATED, but the following code works.
i think we should only throw
ERR_INSPECTOR_ALREADY_ACTIVATED
when there is a inspector thread 🤔.Refs: #33015
cc @joyeecheung
make -j4 test
(UNIX), orvcbuild test
(Windows) passes