Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: upload daily WPT Report to both staging and production #46803

Merged
merged 1 commit into from
Feb 25, 2023
Merged

tools: upload daily WPT Report to both staging and production #46803

merged 1 commit into from
Feb 25, 2023

Conversation

panva
Copy link
Member

@panva panva commented Feb 23, 2023

As per discussion with the wpt.fyi API maintainers, it is advisable to submit to both staging and production systems, given the credentials are the same for both environments this requires no addition to our secrets.

When done we can remove the WPT_FYI_ENDPOINT repo variable from nodejs/node and nodejs/node-auto-test.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/actions

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Feb 23, 2023
@panva panva added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 23, 2023
@panva panva added commit-queue Add this label to land a pull request using GitHub Actions. fast-track PRs that do not need to wait for 48 hours to land. labels Feb 23, 2023
@github-actions

This comment was marked as outdated.

Sign in to view
@panva panva removed the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 23, 2023
bnb
bnb approved these changes Feb 23, 2023
View reviewed changes
Copy link
Contributor

@bnb bnb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Action LGTM

@panva panva added commit-queue Add this label to land a pull request using GitHub Actions. and removed fast-track PRs that do not need to wait for 48 hours to land. labels Feb 24, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 25, 2023
@nodejs-github-bot nodejs-github-bot merged commit b489ae3 into nodejs:main Feb 25, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in b489ae3

@panva panva deleted the wpt-fyi-both-staging-and-prod branch February 25, 2023 19:06
@panva
Copy link
Member Author

panva commented Feb 26, 2023

When done we can remove the WPT_FYI_ENDPOINT repo variable from nodejs/node and nodejs/node-auto-test.

image

targos pushed a commit that referenced this pull request Mar 13, 2023
@panva @targos
tools: upload daily WPT Report to both staging and production
457cb35 
PR-URL: #46803
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Tierney Cyren <[email protected]>
Reviewed-By: James M Snell <[email protected]>
targos pushed a commit that referenced this pull request Mar 14, 2023
@panva @targos
tools: upload daily WPT Report to both staging and production
4b91420 
PR-URL: #46803
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Tierney Cyren <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@targos targos mentioned this pull request Mar 14, 2023
Merged
@danielleadams danielleadams added the dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. label Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aymen94 aymen94 aymen94 approved these changes

@richardlau richardlau richardlau approved these changes

@anonrig anonrig anonrig approved these changes

@bnb bnb bnb approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. meta Issues and PRs related to the general management of the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@panva @nodejs-github-bot @jasnell @bnb @anonrig @richardlau @aymen94 @danielleadams