-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: move bcoe to emeriti #46703
Merged
Merged
doc: move bcoe to emeriti #46703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So long and thanks for all the bike sheds 🚲🏚️ Fixes nodejs#46682
cjihrig
approved these changes
Feb 17, 2023
aduh95
added
fast-track
PRs that do not need to wait for 48 hours to land.
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
labels
Feb 17, 2023
Fast-track has been requested by @aduh95. Please 👍 to approve. |
aduh95
approved these changes
Feb 17, 2023
joyeecheung
approved these changes
Feb 17, 2023
aduh95
added
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Feb 18, 2023
nodejs-github-bot
removed
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Feb 18, 2023
Landed in 7b64cec |
MylesBorins
pushed a commit
that referenced
this pull request
Feb 18, 2023
So long and thanks for all the bike sheds 🚲🏚️ Fixes #46682 PR-URL: #46703 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Feb 20, 2023
So long and thanks for all the bike sheds 🚲🏚️ Fixes #46682 PR-URL: #46703 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Apr 11, 2023
So long and thanks for all the bike sheds 🚲🏚️ Fixes #46682 PR-URL: #46703 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
doc
Issues and PRs related to the documentations.
fast-track
PRs that do not need to wait for 48 hours to land.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So long and thanks for all the bike sheds 🚲🏚
Fixes #46682