Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: fix regex strings in Python tools #46671

Merged
merged 1 commit into from
Feb 21, 2023
Merged

tools: fix regex strings in Python tools #46671

merged 1 commit into from
Feb 21, 2023

Conversation

Trott
Copy link
Member

@Trott Trott commented Feb 15, 2023

Opening this to reland #46585 but this time with the metadata required. Sorry for the mess this has turned out to be for a simple change, @josusky. I hope it's OK that I'm doing this on your behalf. (You're still the author on the commit here.)

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/v8-update

@Trott Trott added the python PRs and issues that require attention from people who are familiar with Python. label Feb 15, 2023
@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. v8 engine Issues and PRs related to the V8 dependency. labels Feb 15, 2023
@Trott Trott added fast-track PRs that do not need to wait for 48 hours to land. and removed build Issues and PRs related to build files or the CI. v8 engine Issues and PRs related to the V8 dependency. tools Issues and PRs related to the tools directory. needs-ci PRs that need a full CI run. labels Feb 15, 2023
@github-actions
Copy link
Contributor

Fast-track has been requested by @Trott. Please 👍 to approve.

@Trott Trott added build Issues and PRs related to build files or the CI. v8 engine Issues and PRs related to the V8 dependency. tools Issues and PRs related to the tools directory. needs-ci PRs that need a full CI run. labels Feb 15, 2023
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. and removed fast-track PRs that do not need to wait for 48 hours to land. labels Feb 16, 2023
@gengjiawen gengjiawen added the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 16, 2023
tniessen
tniessen approved these changes Feb 16, 2023
View reviewed changes
tools/js2c.py Outdated Show resolved Hide resolved
@Trott Trott added commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Feb 16, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 16, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49574/

@nodejs-github-bot
Copy link
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu1804-intel-64,v8test=v8test/5178/

@nodejs-github-bot
Copy link
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/5178/

@nodejs-github-bot
Copy link
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/5178/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49807/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49813/

@josusky @Trott
tools: fix regex strings in Python tools
af935fc 
PR-URL: nodejs#46671
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
@Trott
Copy link
Member Author

Trott commented Feb 21, 2023

Landed in af935fc

@Trott Trott merged commit af935fc into nodejs:main Feb 21, 2023
@Trott Trott deleted the python-patch branch February 21, 2023 19:57
This was referenced Feb 22, 2023
Open
Open
targos pushed a commit that referenced this pull request Mar 13, 2023
@josusky @targos
tools: fix regex strings in Python tools
25ccaa7 
PR-URL: #46671
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
@targos targos mentioned this pull request Mar 14, 2023
Merged
danielleadams pushed a commit that referenced this pull request Apr 11, 2023
@josusky @danielleadams
tools: fix regex strings in Python tools
f80e93d 
PR-URL: #46671
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
@danielleadams danielleadams mentioned this pull request Apr 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RaisinTen RaisinTen RaisinTen approved these changes

@tniessen tniessen tniessen approved these changes

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. build Issues and PRs related to build files or the CI. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. needs-ci PRs that need a full CI run. python PRs and issues that require attention from people who are familiar with Python. tools Issues and PRs related to the tools directory. v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@Trott @nodejs-github-bot @lpinca @tniessen @RaisinTen @gengjiawen @aduh95 @josusky