Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test_runner: top-level diagnostics not ommited when running with --test #46441

Merged
merged 6 commits into from
Feb 2, 2023
Merged

test_runner: top-level diagnostics not ommited when running with --test #46441

merged 6 commits into from
Feb 2, 2023

Conversation

pulkit-30
Copy link
Contributor

@pulkit-30 pulkit-30 commented Jan 31, 2023 •
edited
Loading

fix: #45910

Should not omit top-level diagnostics when running test with --test flag.

Changes

added a logic #checkNestedComment() to filter top-level diagnostics only in cases they are redundant and show them
test:

test('should not omit top-level diagnostics', () => setImmediate(() => done()));

output:

TAP version 13
# Subtest: *
    # Subtest: should not omit top-level diagnostics
    ok 1 - should not omit top-level diagnostics
      ---
      duration_ms: 2.072958
      ...
    1..1
    # Warning: Test "should not omit top-level diagnostics" generated asynchronous activity after the test ended. This activity created the error "ReferenceError: done is not defined" and would have caused the test to fail, but instead triggered an uncaughtException event.
not ok 1 - *
  ---
  duration_ms: 57.882541
  failureType: 'subtestsFailed'
  exitCode: 1
  error: 'test failed'
  code: 'ERR_TEST_FAILURE'
  ...
1..1
# tests 1
# pass 0
# fail 1
# cancelled 0
# skipped 0
# todo 0
# duration_ms 59.641875

I am not sure about test failing
when running test without --test flag, test output is:

TAP version 13
# Subtest: should not omit top-level diagnostics
ok 1 - should not omit top-level diagnostics
  ---
  duration_ms: 2.544125
  ...
1..1
# Warning: Test "should not omit top-level diagnostics" generated asynchronous activity after the test ended. This activity created the error "ReferenceError: done is not defined" and would have caused the test to fail, but instead triggered an uncaughtException event.
# tests 1
# pass 1
# fail 0
# cancelled 0
# skipped 0
# todo 0
# duration_ms 6.197042

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/test_runner

@nodejs-github-bot nodejs-github-bot added dont-land-on-v14.x needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. labels Jan 31, 2023
cjihrig
cjihrig reviewed Jan 31, 2023
View reviewed changes
lib/internal/test_runner/runner.js Outdated Show resolved Hide resolved
lib/internal/test_runner/runner.js Outdated Show resolved Hide resolved
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Feb 1, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 1, 2023
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49294/

@MoLow MoLow added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Feb 1, 2023
@cjihrig cjihrig mentioned this pull request Feb 1, 2023
Merged
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 2, 2023
@nodejs-github-bot nodejs-github-bot merged commit 61c65b0 into nodejs:main Feb 2, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in 61c65b0

@MoLow MoLow mentioned this pull request Feb 2, 2023
Merged
@github-actions github-actions bot mentioned this pull request Feb 5, 2023
Open
22 tasks
MoLow pushed a commit to MoLow/node-core-test that referenced this pull request Feb 7, 2023
@pulkit-30 @MoLow
test_runner: top-level diagnostics not ommited when running with --test
29d5a24 
PR-URL: nodejs/node#46441
Fixes: nodejs/node#45910
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
(cherry picked from commit 61c65b066b098cf47f89206212864ec1cddb8782)
MoLow pushed a commit to MoLow/node-core-test that referenced this pull request Feb 7, 2023
@pulkit-30 @MoLow
fix: top-level diagnostics not ommited when running with --test
2434b16 
PR-URL: nodejs/node#46441
Fixes: nodejs/node#45910
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
(cherry picked from commit 61c65b066b098cf47f89206212864ec1cddb8782)
MoLow pushed a commit to nodejs/node-core-test that referenced this pull request Feb 8, 2023
@pulkit-30 @MoLow
fix: top-level diagnostics not ommited when running with --test
d6f071a 
PR-URL: nodejs/node#46441
Fixes: nodejs/node#45910
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
(cherry picked from commit 61c65b066b098cf47f89206212864ec1cddb8782)
@MoLow MoLow mentioned this pull request Feb 18, 2023
Closed
MoLow pushed a commit to MoLow/node that referenced this pull request Feb 18, 2023
@pulkit-30 @MoLow
test_runner: top-level diagnostics not ommited when running with --test
89a2e2a 
PR-URL: nodejs#46441
Fixes: nodejs#45910
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
MylesBorins pushed a commit that referenced this pull request Feb 18, 2023
@pulkit-30 @MylesBorins
test_runner: top-level diagnostics not ommited when running with --test
b31aabb 
PR-URL: #46441
Fixes: #45910
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Feb 19, 2023
Merged
MoLow pushed a commit to MoLow/node that referenced this pull request Feb 25, 2023
@pulkit-30 @MoLow
test_runner: top-level diagnostics not ommited when running with --test
2e5f8d1 
PR-URL: nodejs#46441
Fixes: nodejs#45910
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
MoLow pushed a commit to MoLow/node that referenced this pull request Feb 25, 2023
@pulkit-30 @MoLow
test_runner: top-level diagnostics not ommited when running with --test
a7c0ee0 
PR-URL: nodejs#46441
Fixes: nodejs#45910
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
@MoLow MoLow added the backport-open-v18.x Indicate that the PR has an open backport. label Feb 25, 2023
MoLow pushed a commit to MoLow/node that referenced this pull request Feb 25, 2023
@pulkit-30 @MoLow
test_runner: top-level diagnostics not ommited when running with --test
e1f5a3a 
PR-URL: nodejs#46441
Fixes: nodejs#45910
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
juanarbol pushed a commit that referenced this pull request Mar 3, 2023
@pulkit-30 @juanarbol
test_runner: top-level diagnostics not ommited when running with --test
a262a67 
PR-URL: #46441
Backport-PR-URL: #46839
Fixes: #45910
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
@juanarbol juanarbol mentioned this pull request Mar 3, 2023
Merged
juanarbol pushed a commit that referenced this pull request Mar 5, 2023
@pulkit-30 @juanarbol
test_runner: top-level diagnostics not ommited when running with --test
c5f16fb 
PR-URL: #46441
Backport-PR-URL: #46839
Fixes: #45910
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig left review comments

@ljharb ljharb ljharb left review comments

@tony-go tony-go tony-go approved these changes

@aduh95 aduh95 aduh95 approved these changes

@MoLow MoLow MoLow approved these changes

@benjamingr benjamingr benjamingr approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. backport-open-v18.x Indicate that the PR has an open backport. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test runner: top-level diagnostics are ommited when running with --test
8 participants
@pulkit-30 @nodejs-github-bot @ljharb @benjamingr @cjihrig @MoLow @aduh95 @tony-go