Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crypto: ensure exported webcrypto EC keys use uncompressed point format #46021

Closed
wants to merge 2 commits into from
Closed

crypto: ensure exported webcrypto EC keys use uncompressed point format #46021

wants to merge 2 commits into from

Conversation

bnoordhuis
Copy link
Member

The WebCrypto spec apparently mandates that EC keys must be exported in uncompressed point format. This commit makes it so.

Fixes: #45859

@bnoordhuis bnoordhuis requested a review from panva December 30, 2022 11:42
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/crypto

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. labels Dec 30, 2022
@bnoordhuis bnoordhuis mentioned this pull request Dec 30, 2022
Closed
panva
panva reviewed Dec 30, 2022
View reviewed changes
Copy link
Member

@panva panva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may remove the "import_export/ec_importKey.https.any.js" block from test/wpt/status/WebCryptoAPI.json

panva
panva reviewed Dec 30, 2022
View reviewed changes
src/crypto/crypto_ec.cc Outdated Show resolved Hide resolved
@panva
Copy link
Member

panva commented Dec 30, 2022

Possibly change the commit and PR title to crypto: ensure exported webcrypto EC keys use uncompressed point format.

@bnoordhuis
src: ensure exported ec keys are uncompressed
ffdc610 
The WebCrypto spec apparently mandates that EC keys must be exported in
uncompressed point format. This commit makes it so.

Fixes: nodejs#45859
@panva panva added request-ci Add this label to start a Jenkins CI on a PR. commit-queue Add this label to land a pull request using GitHub Actions. labels Dec 30, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 30, 2022
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@panva panva removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 30, 2022
This was referenced Dec 31, 2022
Open
Open
@panva panva added commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. request-ci Add this label to start a Jenkins CI on a PR. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Jan 1, 2023
@panva
Copy link
Member

panva commented Jan 1, 2023

One more review would be great.

@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 1, 2023
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48794/

tniessen
tniessen approved these changes Jan 1, 2023
View reviewed changes
Copy link
Member

@tniessen tniessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still LGTM :)

@panva
Copy link
Member

panva commented Jan 1, 2023

Landed in 8ec1b08

panva pushed a commit that referenced this pull request Jan 1, 2023
@bnoordhuis @panva
crypto: ensure exported webcrypto EC keys use uncompressed point format
8ec1b08 
The WebCrypto spec apparently mandates that EC keys must be exported in
uncompressed point format. This commit makes it so.

Fixes: #45859
PR-URL: #46021
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Filip Skokan <[email protected]>
@panva panva closed this Jan 1, 2023
@panva panva changed the title src: ensure exported ec keys are uncompressed crypto: ensure exported webcrypto EC keys use uncompressed point format Jan 1, 2023
@github-actions github-actions bot mentioned this pull request Jan 2, 2023
Open
22 tasks
RafaelGSS pushed a commit that referenced this pull request Jan 2, 2023
@bnoordhuis @RafaelGSS
crypto: ensure exported webcrypto EC keys use uncompressed point format
ca993f3 
The WebCrypto spec apparently mandates that EC keys must be exported in
uncompressed point format. This commit makes it so.

Fixes: #45859
PR-URL: #46021
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Filip Skokan <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Jan 2, 2023
Merged
This was referenced Jan 3, 2023
Open
Open
RafaelGSS pushed a commit that referenced this pull request Jan 4, 2023
@bnoordhuis @RafaelGSS
crypto: ensure exported webcrypto EC keys use uncompressed point format
eb681bc 
The WebCrypto spec apparently mandates that EC keys must be exported in
uncompressed point format. This commit makes it so.

Fixes: #45859
PR-URL: #46021
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Filip Skokan <[email protected]>
@github-actions github-actions bot mentioned this pull request Jan 5, 2023
Open
22 tasks
RafaelGSS pushed a commit that referenced this pull request Jan 5, 2023
@bnoordhuis @RafaelGSS
crypto: ensure exported webcrypto EC keys use uncompressed point format
777c551 
The WebCrypto spec apparently mandates that EC keys must be exported in
uncompressed point format. This commit makes it so.

Fixes: #45859
PR-URL: #46021
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Filip Skokan <[email protected]>
juanarbol pushed a commit that referenced this pull request Jan 26, 2023
@bnoordhuis @juanarbol
crypto: ensure exported webcrypto EC keys use uncompressed point format
d83f7ee 
The WebCrypto spec apparently mandates that EC keys must be exported in
uncompressed point format. This commit makes it so.

Fixes: #45859
PR-URL: #46021
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Filip Skokan <[email protected]>
@juanarbol juanarbol mentioned this pull request Jan 28, 2023
Merged
juanarbol pushed a commit that referenced this pull request Jan 31, 2023
@bnoordhuis @juanarbol
crypto: ensure exported webcrypto EC keys use uncompressed point format
782b6f6 
The WebCrypto spec apparently mandates that EC keys must be exported in
uncompressed point format. This commit makes it so.

Fixes: #45859
PR-URL: #46021
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Filip Skokan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@panva panva panva approved these changes

@tniessen tniessen tniessen approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. webcrypto
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

WebCryptoAPI EC key SPKI export does not always use uncompressed point format
4 participants
@bnoordhuis @nodejs-github-bot @panva @tniessen