Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vm: refactor to use validateStringArray #46020

Merged
merged 1 commit into from
Jan 1, 2023
Merged

vm: refactor to use validateStringArray #46020

merged 1 commit into from
Jan 1, 2023

Conversation

deokjinkim
Copy link
Contributor

No description provided.

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. vm Issues and PRs related to the vm subsystem. labels Dec 30, 2022
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Dec 30, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 30, 2022
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48767/

@targos targos added the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 1, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 1, 2023
@nodejs-github-bot nodejs-github-bot merged commit 5e43f3d into nodejs:main Jan 1, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in 5e43f3d

RafaelGSS pushed a commit that referenced this pull request Jan 2, 2023
@deokjinkim @RafaelGSS
vm: refactor to use validateStringArray
6f1a180 
PR-URL: #46020
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Jan 2, 2023
Merged
RafaelGSS pushed a commit that referenced this pull request Jan 4, 2023
@deokjinkim @RafaelGSS
vm: refactor to use validateStringArray
6ddfabe 
PR-URL: #46020
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Jan 5, 2023
@deokjinkim @RafaelGSS
vm: refactor to use validateStringArray
389cc3e 
PR-URL: #46020
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
juanarbol pushed a commit that referenced this pull request Jan 26, 2023
@deokjinkim @juanarbol
vm: refactor to use validateStringArray
d46f974 
PR-URL: #46020
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
@juanarbol juanarbol mentioned this pull request Jan 28, 2023
Merged
juanarbol pushed a commit that referenced this pull request Jan 31, 2023
@deokjinkim @juanarbol
vm: refactor to use validateStringArray
96f1b2e 
PR-URL: #46020
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aduh95 aduh95 aduh95 approved these changes

@JungMinu JungMinu JungMinu approved these changes

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. vm Issues and PRs related to the vm subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@deokjinkim @nodejs-github-bot @lpinca @JungMinu @aduh95 @targos