Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

meta: add nodejs/loaders to CODEOWNERS #45940

Merged
merged 1 commit into from
Dec 24, 2022
Merged

meta: add nodejs/loaders to CODEOWNERS #45940

merged 1 commit into from
Dec 24, 2022

Conversation

GeoffreyBooth
Copy link
Member

Updating the paths for module- and loaders-related files and adding @nodejs/loaders to CODEOWNERS.

@GeoffreyBooth GeoffreyBooth requested a review from aduh95 December 22, 2022 05:36
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/tsc

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Dec 22, 2022
@GeoffreyBooth GeoffreyBooth added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Dec 22, 2022
JakobJingleheimer
JakobJingleheimer approved these changes Dec 23, 2022
View reviewed changes
Copy link
Member

@JakobJingleheimer JakobJingleheimer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 24, 2022
@nodejs-github-bot nodejs-github-bot merged commit fbae17a into nodejs:main Dec 24, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in fbae17a

@GeoffreyBooth GeoffreyBooth deleted the loaders-codeowners branch December 24, 2022 06:24
targos pushed a commit that referenced this pull request Jan 1, 2023
@GeoffreyBooth @targos
meta: add nodejs/loaders to CODEOWNERS
e0c6146 
PR-URL: #45940
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Jacob Smith <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Jan 2, 2023
Merged
RafaelGSS pushed a commit that referenced this pull request Jan 4, 2023
@GeoffreyBooth @RafaelGSS
meta: add nodejs/loaders to CODEOWNERS
3fd55d6 
PR-URL: #45940
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Jacob Smith <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Jan 5, 2023
@GeoffreyBooth @RafaelGSS
meta: add nodejs/loaders to CODEOWNERS
86e30fc 
PR-URL: #45940
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Jacob Smith <[email protected]>
juanarbol pushed a commit that referenced this pull request Jan 26, 2023
@GeoffreyBooth @juanarbol
meta: add nodejs/loaders to CODEOWNERS
f3a7417 
PR-URL: #45940
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Jacob Smith <[email protected]>
@juanarbol juanarbol mentioned this pull request Jan 28, 2023
Merged
juanarbol pushed a commit that referenced this pull request Jan 31, 2023
@GeoffreyBooth @juanarbol
meta: add nodejs/loaders to CODEOWNERS
10a276a 
PR-URL: #45940
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Jacob Smith <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RaisinTen RaisinTen RaisinTen approved these changes

@RafaelGSS RafaelGSS RafaelGSS approved these changes

@aduh95 aduh95 aduh95 approved these changes

@legendecas legendecas legendecas approved these changes

@JakobJingleheimer JakobJingleheimer JakobJingleheimer approved these changes

@benjamingr benjamingr benjamingr approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. meta Issues and PRs related to the general management of the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@GeoffreyBooth @nodejs-github-bot @benjamingr @JakobJingleheimer @legendecas @aduh95 @RafaelGSS @RaisinTen