test: use `process.hrtime.bigint` instead of `process.hrtime` #45877

deokjinkim · 2022-12-16T04:30:59Z

process.hrtime is legacy. So replace process.hrtime with process.hrtime.bigint in test.

Refs: https://github.com/nodejs/node/blob/main/doc/api/process.md#processhrtimetime
Refs: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/BigInt

Signed-off-by: Deokjin Kim [email protected]

`process.hrtime` is legacy. So replace `process.hrtime` with `process.hrtime.bigint` in test. Refs: https://github.com/nodejs/node/blob/main/doc/api/process.md#processhrtimetime Signed-off-by: Deokjin Kim <[email protected]>

aduh95 · 2022-12-16T17:14:29Z

test/parallel/test-http2-session-timeout.js

@@ -5,6 +5,8 @@ if (!common.hasCrypto)
  common.skip('missing crypto');
 const assert = require('assert');
 const http2 = require('http2');
+const hrtime = process.hrtime.bigint;
+const NS_PER_MS = 1000000n;


Suggested change

const NS_PER_MS = 1000000n;

const NS_PER_MS = 1_000_000n;

Applied your suggestion. Thank you for suggestion.

nodejs-github-bot · 2022-12-17T10:42:13Z

CI: https://ci.nodejs.org/job/node-test-pull-request/48542/

nodejs-github-bot · 2022-12-19T16:58:58Z

CI: https://ci.nodejs.org/job/node-test-pull-request/48590/

nodejs-github-bot · 2022-12-28T11:55:39Z

CI: https://ci.nodejs.org/job/node-test-pull-request/48749/

nodejs-github-bot · 2023-01-01T10:57:41Z

Commit Queue failed

- Loading data for nodejs/node/pull/45877 ✔ Done loading data for nodejs/node/pull/45877 ----------------------------------- PR info ------------------------------------ Title test: use `process.hrtime.bigint` instead of `process.hrtime` (#45877) Author Deokjin Kim (@deokjinkim) Branch deokjinkim:221216_use_hrtime_bigint -> nodejs:main Labels test, author ready, needs-ci Commits 2 - test: use `process.hrtime.bigint` instead of `process.hrtime` - Revise format of NS_PER_MS Committers 1 - Deokjin Kim PR-URL: https://github.com/nodejs/node/pull/45877 Refs: https://github.com/nodejs/node/blob/main/doc/api/process.md#processhrtimetime Refs: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/BigInt Reviewed-By: James M Snell Reviewed-By: Antoine du Hamel ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/45877 Refs: https://github.com/nodejs/node/blob/main/doc/api/process.md#processhrtimetime Refs: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/BigInt Reviewed-By: James M Snell Reviewed-By: Antoine du Hamel -------------------------------------------------------------------------------- ℹ This PR was created on Fri, 16 Dec 2022 04:30:59 GMT ✔ Approvals: 2 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/45877#pullrequestreview-1223228434 ✔ - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/45877#pullrequestreview-1223230198 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2022-12-28T11:55:39Z: https://ci.nodejs.org/job/node-test-pull-request/48749/ - Querying data for job/node-test-pull-request/48749/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 45877 From https://github.com/nodejs/node * branch refs/pull/45877/merge -> FETCH_HEAD ✔ Fetched commits as 5e43f3d77694..ecc7caabeb39 -------------------------------------------------------------------------------- [main 3232ff220d] test: use `process.hrtime.bigint` instead of `process.hrtime` Author: Deokjin Kim Date: Fri Dec 16 13:27:05 2022 +0900 1 file changed, 10 insertions(+), 8 deletions(-) [main 89e27a7a55] Revise format of NS_PER_MS Author: Deokjin Kim Date: Sat Dec 17 02:56:22 2022 +0900 1 file changed, 1 insertion(+), 1 deletion(-) ✔ Patches applied There are 2 commits in the PR. Attempting autorebase. Rebasing (2/4)

Executing: git node land --amend --yes
⚠ Found Refs: https://github.com/nodejs/node/blob/main/doc/api/process.md#processhrtimetime, skipping..
--------------------------------- New Message ----------------------------------
test: use process.hrtime.bigint instead of process.hrtime

process.hrtime is legacy. So replace process.hrtime with
process.hrtime.bigint in test.

Refs: https://github.com/nodejs/node/blob/main/doc/api/process.md#processhrtimetime

Signed-off-by: Deokjin Kim [email protected]
PR-URL: #45877
Refs: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/BigInt
Reviewed-By: James M Snell [email protected]
Reviewed-By: Antoine du Hamel [email protected]

[detached HEAD f391a04f1b] test: use process.hrtime.bigint instead of process.hrtime
Author: Deokjin Kim [email protected]
Date: Fri Dec 16 13:27:05 2022 +0900
1 file changed, 10 insertions(+), 8 deletions(-)
Rebasing (3/4)
Rebasing (4/4)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
Revise format of NS_PER_MS

PR-URL: #45877
Refs: https://github.com/nodejs/node/blob/main/doc/api/process.md#processhrtimetime
Refs: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/BigInt
Reviewed-By: James M Snell [email protected]
Reviewed-By: Antoine du Hamel [email protected]

[detached HEAD 95473f359c] Revise format of NS_PER_MS
Author: Deokjin Kim [email protected]
Date: Sat Dec 17 02:56:22 2022 +0900
1 file changed, 1 insertion(+), 1 deletion(-)

Successfully rebased and updated refs/heads/main.

ℹ Add commit-queue-squash label to land the PR as one commit, or commit-queue-rebase to land as separate commits.

https://github.com/nodejs/node/actions/runs/3816511183

nodejs-github-bot · 2023-01-01T11:07:48Z

Landed in 4b9f94b

`process.hrtime` is legacy. So replace `process.hrtime` with `process.hrtime.bigint` in test. Refs: https://github.com/nodejs/node/blob/main/doc/api/process.md#processhrtimetime Signed-off-by: Deokjin Kim <[email protected]> PR-URL: #45877 Refs: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/BigInt Reviewed-By: James M Snell <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>

nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Dec 16, 2022

deokjinkim force-pushed the 221216_use_hrtime_bigint branch from b347bf0 to ea38ffc Compare December 16, 2022 04:33

test: use process.hrtime.bigint instead of process.hrtime

6b0e8d6

`process.hrtime` is legacy. So replace `process.hrtime` with `process.hrtime.bigint` in test. Refs: https://github.com/nodejs/node/blob/main/doc/api/process.md#processhrtimetime Signed-off-by: Deokjin Kim <[email protected]>

deokjinkim force-pushed the 221216_use_hrtime_bigint branch from ea38ffc to 6b0e8d6 Compare December 16, 2022 08:35

aduh95 reviewed Dec 16, 2022

View reviewed changes

Revise format of NS_PER_MS

ecc7caa

aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 17, 2022

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 17, 2022

This was referenced Dec 18, 2022

CI Reliability 2022-12-18 nodejs/reliability#461

Open

CI Reliability 2022-12-19 nodejs/reliability#462

Open

jasnell approved these changes Dec 19, 2022

View reviewed changes

aduh95 approved these changes Dec 19, 2022

View reviewed changes

aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 19, 2022

This was referenced Dec 20, 2022

CI Reliability 2022-12-20 nodejs/reliability#463

Open

CI Reliability 2022-12-21 nodejs/reliability#464

Open

CI Reliability 2022-12-22 nodejs/reliability#465

Open

targos added the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 1, 2023

nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Jan 1, 2023

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 1, 2023

nodejs-github-bot merged commit 4b9f94b into nodejs:main Jan 1, 2023

RafaelGSS mentioned this pull request Jan 2, 2023

v19.4.0 proposal #46061

Merged

juanarbol mentioned this pull request Jan 28, 2023

V18.14.0 proposal #46396

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test: use `process.hrtime.bigint` instead of `process.hrtime` #45877

test: use `process.hrtime.bigint` instead of `process.hrtime` #45877

deokjinkim commented Dec 16, 2022 •

edited

Loading

aduh95 Dec 16, 2022

deokjinkim Dec 16, 2022

nodejs-github-bot commented Dec 17, 2022

nodejs-github-bot commented Dec 19, 2022

nodejs-github-bot commented Dec 28, 2022

nodejs-github-bot commented Jan 1, 2023

Signed-off-by: Deokjin Kim [email protected]
PR-URL: #45877
Refs: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/BigInt
Reviewed-By: James M Snell [email protected]
Reviewed-By: Antoine du Hamel [email protected]

PR-URL: #45877
Refs: https://github.com/nodejs/node/blob/main/doc/api/process.md#processhrtimetime
Refs: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/BigInt
Reviewed-By: James M Snell [email protected]
Reviewed-By: Antoine du Hamel [email protected]

Successfully rebased and updated refs/heads/main.

nodejs-github-bot commented Jan 1, 2023

test: use process.hrtime.bigint instead of process.hrtime #45877

test: use process.hrtime.bigint instead of process.hrtime #45877

Conversation

deokjinkim commented Dec 16, 2022 • edited Loading

aduh95 Dec 16, 2022

Choose a reason for hiding this comment

deokjinkim Dec 16, 2022

Choose a reason for hiding this comment

nodejs-github-bot commented Dec 17, 2022

nodejs-github-bot commented Dec 19, 2022

nodejs-github-bot commented Dec 28, 2022

nodejs-github-bot commented Jan 1, 2023

Signed-off-by: Deokjin Kim [email protected] PR-URL: #45877 Refs: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/BigInt Reviewed-By: James M Snell [email protected] Reviewed-By: Antoine du Hamel [email protected]

PR-URL: #45877 Refs: https://github.com/nodejs/node/blob/main/doc/api/process.md#processhrtimetime Refs: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/BigInt Reviewed-By: James M Snell [email protected] Reviewed-By: Antoine du Hamel [email protected]

Successfully rebased and updated refs/heads/main.

nodejs-github-bot commented Jan 1, 2023

test: use `process.hrtime.bigint` instead of `process.hrtime` #45877

test: use `process.hrtime.bigint` instead of `process.hrtime` #45877

deokjinkim commented Dec 16, 2022 •

edited

Loading

Signed-off-by: Deokjin Kim [email protected]
PR-URL: #45877
Refs: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/BigInt
Reviewed-By: James M Snell [email protected]
Reviewed-By: Antoine du Hamel [email protected]

PR-URL: #45877
Refs: https://github.com/nodejs/node/blob/main/doc/api/process.md#processhrtimetime
Refs: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/BigInt
Reviewed-By: James M Snell [email protected]
Reviewed-By: Antoine du Hamel [email protected]