Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: remove Juan Jose keys #45827

Merged
merged 1 commit into from
Dec 14, 2022
Merged

doc: remove Juan Jose keys #45827

merged 1 commit into from
Dec 14, 2022

Conversation

RafaelGSS
Copy link
Member

@RafaelGSS RafaelGSS commented Dec 12, 2022 •
edited
Loading

Juan doesn't have access to this key anymore. Once he gets a new machine, we will include the new key.

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Dec 12, 2022
juanarbol
juanarbol approved these changes Dec 12, 2022
View reviewed changes
Copy link
Member

@juanarbol juanarbol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cjihrig
Copy link
Contributor

cjihrig commented Dec 12, 2022

I think this key needs to be added to the "Other keys used to sign some previous releases" section.

@cjihrig
Copy link
Contributor

cjihrig commented Dec 12, 2022

Juan is also listed under Security release stewards. Does that need to be updated?

@RafaelGSS
Copy link
Member Author

Juan is also listed under Security release stewards. Does that need to be updated?

Juan will still be a releaser. He just doesn't have access to this key anymore. Once he gets a new machine, he will include a new one

@cjihrig
Copy link
Contributor

cjihrig commented Dec 12, 2022

Got it. Thanks. A note in the commit message or PR description would be helpful.

@bnoordhuis
Copy link
Member

So what happened to his key? If evil-doer Eve gets hold of it, she can use it to sign a malicious binary and send that to Alice, and since his key is still listed in the readme, Alice is going to think it's legit.

@GeoffreyBooth GeoffreyBooth added the fast-track PRs that do not need to wait for 48 hours to land. label Dec 14, 2022
@github-actions
Copy link
Contributor

Fast-track has been requested by @GeoffreyBooth. Please 👍 to approve.

@RafaelGSS RafaelGSS added the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 14, 2022
@RafaelGSS
Copy link
Member Author

So what happened to his key? If evil-doer Eve gets hold of it, she can use it to sign a malicious binary and send that to Alice, and since his key is still listed in the readme, Alice is going to think it's legit.

Hi Ben! I've sent you an email.

@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 14, 2022
@nodejs-github-bot nodejs-github-bot merged commit b3f5a41 into nodejs:main Dec 14, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in b3f5a41

targos pushed a commit that referenced this pull request Jan 1, 2023
@RafaelGSS @targos
doc: remove Juan Jose keys
c86f4a1 
PR-URL: #45827
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Jan 2, 2023
Merged
juanarbol pushed a commit that referenced this pull request Jan 26, 2023
@RafaelGSS @juanarbol
doc: remove Juan Jose keys
f874d0b 
PR-URL: #45827
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
@juanarbol juanarbol mentioned this pull request Jan 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juanarbol juanarbol juanarbol approved these changes

@BethGriggs BethGriggs BethGriggs approved these changes

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@RafaelGSS @cjihrig @bnoordhuis @nodejs-github-bot @lpinca @BethGriggs @juanarbol @GeoffreyBooth