Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test_runner: parse yaml #45815

Merged
merged 12 commits into from
Dec 13, 2022
Merged

test_runner: parse yaml #45815

merged 12 commits into from
Dec 13, 2022

Conversation

MoLow
Copy link
Member

@MoLow MoLow commented Dec 11, 2022

prior to #45712
this will enable reporters to display raw details the same way when running with and without --test

@nodejs-github-bot nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Dec 11, 2022
@MoLow MoLow added dont-land-on-v14.x test_runner Issues and PRs related to the test runner subsystem. labels Dec 11, 2022
@MoLow
Copy link
Member Author

MoLow commented Dec 11, 2022

CC @nodejs/test_runner

@MoLow MoLow force-pushed the test-runner-parse-yaml branch from 79b7813 to 6e9dad3 Compare December 11, 2022 11:19
cjihrig
cjihrig approved these changes Dec 11, 2022
View reviewed changes
lib/internal/test_runner/yaml_parser.js Show resolved Hide resolved
lib/internal/test_runner/yaml_parser.js Outdated Show resolved Hide resolved
@MoLow MoLow added the commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. label Dec 11, 2022
@MoLow MoLow requested a review from aduh95 December 12, 2022 06:52
aduh95
aduh95 reviewed Dec 12, 2022
View reviewed changes
lib/internal/test_runner/yaml_parser.js Outdated Show resolved Hide resolved
lib/internal/test_runner/yaml_parser.js Outdated Show resolved Hide resolved
lib/internal/test_runner/yaml_parser.js Outdated Show resolved Hide resolved
lib/internal/test_runner/yaml_parser.js Outdated Show resolved Hide resolved
lib/internal/test_runner/yaml_parser.js Outdated Show resolved Hide resolved
lib/internal/test_runner/yaml_parser.js Outdated Show resolved Hide resolved
@MoLow MoLow requested a review from aduh95 December 12, 2022 08:11
benjamingr
benjamingr approved these changes Dec 12, 2022
View reviewed changes
Copy link
Member

@benjamingr benjamingr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly not sure about this, this adds a (non compliant) yaml parser without adding (actual) tests for it.

But this is an experimental API so I'm fine with landing and discussing later.

@MoLow MoLow force-pushed the test-runner-parse-yaml branch from 3fef532 to c414f22 Compare December 12, 2022 12:00
@MoLow MoLow added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 12, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 12, 2022
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48426/

@MoLow MoLow added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 13, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 13, 2022
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48446/

@MoLow MoLow added the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 13, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 13, 2022
@nodejs-github-bot nodejs-github-bot merged commit 232efb0 into nodejs:main Dec 13, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in 232efb0

@MoLow MoLow deleted the test-runner-parse-yaml branch December 13, 2022 14:52
@ljharb
Copy link
Member

ljharb commented Dec 13, 2022

This is still an incomplete Yaml parser in a file called “Yaml parser” - is it intended to be made complete?

@MoLow
Copy link
Member Author

MoLow commented Dec 13, 2022

This is still an incomplete Yaml parser in a file called “Yaml parser” - is it intended to be made complete?

I will rename the file in the reporters PR theb

This was referenced Dec 14, 2022
Open
Open
Open
targos pushed a commit that referenced this pull request Jan 1, 2023
@MoLow @targos
test_runner: parse yaml
bdbb676 
PR-URL: #45815
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Jan 2, 2023
Merged
MoLow added a commit to MoLow/node that referenced this pull request Jan 26, 2023
@MoLow
test_runner: parse yaml
30c5d6c 
PR-URL: nodejs#45815
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
MoLow added a commit to MoLow/node that referenced this pull request Jan 26, 2023
@MoLow
test_runner: parse yaml
f4db14a 
PR-URL: nodejs#45815
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
@MoLow MoLow mentioned this pull request Jan 26, 2023
Closed
@MoLow MoLow added the backport-open-v18.x Indicate that the PR has an open backport. label Jan 26, 2023
juanarbol pushed a commit that referenced this pull request Jan 26, 2023
@MoLow @juanarbol
test_runner: parse yaml
87a0e86 
PR-URL: #45815
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
@MoLow MoLow removed the backport-open-v18.x Indicate that the PR has an open backport. label Jan 26, 2023
@juanarbol juanarbol mentioned this pull request Jan 28, 2023
Merged
MoLow added a commit to MoLow/node-core-test that referenced this pull request Feb 2, 2023
@MoLow
feat: parse yaml
d1343a7 
PR-URL: nodejs/node#45815
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
(cherry picked from commit 232efb06fe8787e9573e298ce7ac293ad23b7684)
codebytere added a commit to electron/electron that referenced this pull request Feb 6, 2023
@codebytere
test_runner: parse yaml
ad0a5e2 
nodejs/node#45815
jkleinsc pushed a commit to electron/electron that referenced this pull request Feb 7, 2023
@electron-roller @codebytere
chore: bump node to v18.14.0 (main) (#37129)
de607cb 
* chore: bump node in DEPS to v18.14.0

* src: add support for externally shared js builtins

nodejs/node#44376

* test: fix test broken under --node-builtin-modules-path

nodejs/node#45894

* build: add option to disable shared readonly heap

nodejs/node#45887

* src: remove unnecessary semicolons

nodejs/node#46171

* src: remove return after abort

nodejs/node#46172

* chore: fixup patch indices

* test_runner: parse yaml

nodejs/node#45815

* src: use simdutf for converting externalized builtins to UTF-16

nodejs/node#46119

* src: rename internal module declaration as internal bindings

nodejs/node#45551

---------

Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <[email protected]>
khalwa pushed a commit to solarwindscloud/electron that referenced this pull request Feb 22, 2023
@electron-roller @codebytere @khalwa
chore: bump node to v18.14.0 (main) (electron#37129)
a3a8cf5 
* chore: bump node in DEPS to v18.14.0

* src: add support for externally shared js builtins

nodejs/node#44376

* test: fix test broken under --node-builtin-modules-path

nodejs/node#45894

* build: add option to disable shared readonly heap

nodejs/node#45887

* src: remove unnecessary semicolons

nodejs/node#46171

* src: remove return after abort

nodejs/node#46172

* chore: fixup patch indices

* test_runner: parse yaml

nodejs/node#45815

* src: use simdutf for converting externalized builtins to UTF-16

nodejs/node#46119

* src: rename internal module declaration as internal bindings

nodejs/node#45551

---------

Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <[email protected]>
gecko19 pushed a commit to brightsign/electron that referenced this pull request Feb 28, 2023
@electron-roller @codebytere @gecko19
chore: bump node to v18.14.0 (main) (electron#37129)
cb27024 
* chore: bump node in DEPS to v18.14.0

* src: add support for externally shared js builtins

nodejs/node#44376

* test: fix test broken under --node-builtin-modules-path

nodejs/node#45894

* build: add option to disable shared readonly heap

nodejs/node#45887

* src: remove unnecessary semicolons

nodejs/node#46171

* src: remove return after abort

nodejs/node#46172

* chore: fixup patch indices

* test_runner: parse yaml

nodejs/node#45815

* src: use simdutf for converting externalized builtins to UTF-16

nodejs/node#46119

* src: rename internal module declaration as internal bindings

nodejs/node#45551

---------

Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <[email protected]>
gecko19 pushed a commit to brightsign/electron that referenced this pull request Mar 15, 2023
@electron-roller @codebytere @gecko19
chore: bump node to v18.14.0 (main) (electron#37129)
999db88 
* chore: bump node in DEPS to v18.14.0

* src: add support for externally shared js builtins

nodejs/node#44376

* test: fix test broken under --node-builtin-modules-path

nodejs/node#45894

* build: add option to disable shared readonly heap

nodejs/node#45887

* src: remove unnecessary semicolons

nodejs/node#46171

* src: remove return after abort

nodejs/node#46172

* chore: fixup patch indices

* test_runner: parse yaml

nodejs/node#45815

* src: use simdutf for converting externalized builtins to UTF-16

nodejs/node#46119

* src: rename internal module declaration as internal bindings

nodejs/node#45551

---------

Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <[email protected]>
gecko19 pushed a commit to brightsign/electron that referenced this pull request Mar 15, 2023
@electron-roller @codebytere @gecko19
chore: bump node to v18.14.0 (main) (electron#37129)
1323f07 
* chore: bump node in DEPS to v18.14.0

* src: add support for externally shared js builtins

nodejs/node#44376

* test: fix test broken under --node-builtin-modules-path

nodejs/node#45894

* build: add option to disable shared readonly heap

nodejs/node#45887

* src: remove unnecessary semicolons

nodejs/node#46171

* src: remove return after abort

nodejs/node#46172

* chore: fixup patch indices

* test_runner: parse yaml

nodejs/node#45815

* src: use simdutf for converting externalized builtins to UTF-16

nodejs/node#46119

* src: rename internal module declaration as internal bindings

nodejs/node#45551

---------

Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@ljharb ljharb ljharb left review comments

@aduh95 aduh95 aduh95 approved these changes

@benjamingr benjamingr benjamingr approved these changes

Assignees
No one assigned
Labels
commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@MoLow @nodejs-github-bot @ljharb @benjamingr @cjihrig @aduh95