Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Aix: Fix V8 canary build #45496

Merged
merged 1 commit into from
Nov 19, 2022
Merged

Aix: Fix V8 canary build #45496

merged 1 commit into from
Nov 19, 2022

Conversation

V-for-Vasili
Copy link
Contributor

Use -fno-extern-tls-init to avoid link error with extern thread_local

Fixes: nodejs/node-v8#234 (comment)

Related (gcc bug):
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100641

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/gyp
  • @nodejs/v8-update

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. v8 engine Issues and PRs related to the V8 dependency. labels Nov 17, 2022
@V-for-Vasili V-for-Vasili force-pushed the Aix-fno-extern-tls-init-flag branch from ce6d0ff to c766a9e Compare November 17, 2022 16:05
@V-for-Vasili V-for-Vasili force-pushed the Aix-fno-extern-tls-init-flag branch from c766a9e to 37c6beb Compare November 17, 2022 16:09
@V-for-Vasili V-for-Vasili marked this pull request as ready for review November 17, 2022 16:33
@V-for-Vasili V-for-Vasili mentioned this pull request Nov 17, 2022
Closed
@anonrig anonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 17, 2022
@anonrig anonrig added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 17, 2022
cjihrig
cjihrig reviewed Nov 17, 2022
View reviewed changes
Copy link
Contributor

@cjihrig cjihrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look ok if the CI passes

@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 17, 2022
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47991/

@nodejs-github-bot
Copy link
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu1804-intel-64,v8test=v8test/4994/

@nodejs-github-bot
Copy link
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/4994/

@nodejs-github-bot
Copy link
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/4994/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47998/

@github-actions github-actions bot mentioned this pull request Nov 18, 2022
Open
12 tasks
@targos
Copy link
Member

targos commented Nov 18, 2022

Test with this on top of V8 lkgr: https://ci.nodejs.org/job/node-test-commit-aix/43755/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48006/

@anonrig anonrig added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 18, 2022
@github-actions github-actions bot mentioned this pull request Nov 19, 2022
Open
10 tasks
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 19, 2022
@nodejs-github-bot nodejs-github-bot merged commit 87e6943 into nodejs:main Nov 19, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in 87e6943

This was referenced Nov 20, 2022
Open
Open
ruyadorno pushed a commit that referenced this pull request Nov 21, 2022
@V-for-Vasili @ruyadorno
gyp: fix v8 canary build on aix
e0a271e 
PR-URL: #45496
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Ujjwal Sharma <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
@github-actions github-actions bot mentioned this pull request Nov 22, 2022
Open
15 tasks
marco-ippolito pushed a commit to marco-ippolito/node that referenced this pull request Nov 23, 2022
@V-for-Vasili @marco-ippolito
gyp: fix v8 canary build on aix
cba5204 
PR-URL: nodejs#45496
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Ujjwal Sharma <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
@ruyadorno ruyadorno mentioned this pull request Nov 24, 2022
Merged
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@V-for-Vasili @danielleadams
gyp: fix v8 canary build on aix
efee3d9 
PR-URL: #45496
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Ujjwal Sharma <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
@danielleadams danielleadams mentioned this pull request Dec 30, 2022
Merged
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@V-for-Vasili @danielleadams
gyp: fix v8 canary build on aix
57276c4 
PR-URL: #45496
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Ujjwal Sharma <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
@V-for-Vasili @danielleadams
gyp: fix v8 canary build on aix
9ab00f5 
PR-URL: #45496
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Ujjwal Sharma <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 4, 2023
@V-for-Vasili @danielleadams
gyp: fix v8 canary build on aix
d84843c 
PR-URL: #45496
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Ujjwal Sharma <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 5, 2023
@V-for-Vasili @danielleadams
gyp: fix v8 canary build on aix
1dda8da 
PR-URL: #45496
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Ujjwal Sharma <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryzokuken ryzokuken ryzokuken approved these changes

@richardlau richardlau richardlau approved these changes

@cjihrig cjihrig cjihrig approved these changes

@targos targos targos approved these changes

@anonrig anonrig anonrig approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Review state of canary in CI
7 participants
@V-for-Vasili @nodejs-github-bot @targos @anonrig @cjihrig @richardlau @ryzokuken