-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
src: condense experimental warning message #45424
Conversation
Hmmm...that didn't work...guess the punctuation gets pulled out later on..... |
Ideally, I think, this would be just one sentence (which it is now) and might omit the period if it is being followed by a stack trace but include a period if it isn't. |
Leaving the period off when it's a single sentence isn't as weird and noticeable as when it's multiple sentences so I think I'll leave it like that. |
Honestly, I wonder if the message would be better as just " is an experimental feature" and that's it. That would probably get these messages under 80 chars for the most part and probably not reduce their effectiveness. "Might change at any time" is kind of weird anyway. It's not going to change at any time. It's going to change when there's a new release and the user updates. I'd think "experimental" is plenty scary enough and we don't need to explicitly warn people that the feature might change. |
There are test failures to address.
I guess it's there to communicate that semver rules don't apply for experimental features. |
Landed in 1255db7 |
PR-URL: #45424 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Moshe Atlow <[email protected]>
PR-URL: #45424 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Moshe Atlow <[email protected]>
PR-URL: #45424 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Moshe Atlow <[email protected]>
PR-URL: #45424 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Moshe Atlow <[email protected]>
PR-URL: #45424 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Moshe Atlow <[email protected]>
Before:
After: