tools: simplify .eslintrc.js #45397
Merged
tools: simplify .eslintrc.js #45397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove explicit setting of configuration options in rules when those options are the defaults.
|
Do we have any easy way of telling if the defaults change in the future? |
Probably not. I suppose that could be a case for never using the defaults implicitly and spelling everything out in the config file, but I would prefer to go in the opposite direction of configuration file simplicity. |
joyeecheung
approved these changes
Nov 10, 2022
lpinca
approved these changes
Nov 10, 2022
Trott
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 9baf748 |
ruyadorno
pushed a commit
that referenced
this pull request
Nov 21, 2022
Remove explicit setting of configuration options in rules when those options are the defaults. PR-URL: #45397 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Merged
danielleadams
pushed a commit
that referenced
this pull request
Dec 30, 2022
Remove explicit setting of configuration options in rules when those options are the defaults. PR-URL: #45397 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Dec 30, 2022
Remove explicit setting of configuration options in rules when those options are the defaults. PR-URL: #45397 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Jan 3, 2023
Remove explicit setting of configuration options in rules when those options are the defaults. PR-URL: #45397 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Jan 4, 2023
Remove explicit setting of configuration options in rules when those options are the defaults. PR-URL: #45397 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove explicit setting of configuration options in rules when those options are the defaults.