fs: protect fs.watch from monkeypatches #45265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
fs
5 tasks
github-actions
bot
removed
the
request-ci
aduh95
approved these changes
Nov 1, 2022
aduh95
added
the
author ready
|
Fast-track has been requested by @anonrig. Please 👍 to approve. |
RafaelGSS
approved these changes
Nov 1, 2022
MoLow
approved these changes
Nov 1, 2022
anonrig
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/45265 ✔ Done loading data for nodejs/node/pull/45265 ----------------------------------- PR info ------------------------------------ Title fs: protect fs.watch from monkeypatches (#45265) Author Yagiz Nizipli (@anonrig) Branch anonrig:fs/recursive-followup -> nodejs:main Labels fs, fast-track, author ready, needs-ci Commits 2 - fs: update todo message - fs: protect fs.watch from monkeypatches Committers 1 - Yagiz Nizipli PR-URL: https://github.com/nodejs/node/pull/45265 Reviewed-By: Antoine du Hamel Reviewed-By: Rafael Gonzaga Reviewed-By: Moshe Atlow ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/45265 Reviewed-By: Antoine du Hamel Reviewed-By: Rafael Gonzaga Reviewed-By: Moshe Atlow -------------------------------------------------------------------------------- ℹ This PR was created on Tue, 01 Nov 2022 13:52:48 GMT ✔ Approvals: 3 ✔ - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/45265#pullrequestreview-1163697719 ✔ - Rafael Gonzaga (@RafaelGSS): https://github.com/nodejs/node/pull/45265#pullrequestreview-1163772612 ✔ - Moshe Atlow (@MoLow): https://github.com/nodejs/node/pull/45265#pullrequestreview-1163822822 ℹ This PR is being fast-tracked ✔ Last GitHub CI successful ℹ Last Full PR CI on 2022-11-01T13:59:09Z: https://ci.nodejs.org/job/node-test-pull-request/47617/ - Querying data for job/node-test-pull-request/47617/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 45265 From https://github.com/nodejs/node * branch refs/pull/45265/merge -> FETCH_HEAD ✔ Fetched commits as acd6f6c6082f..1673db412c4b -------------------------------------------------------------------------------- [main 1e03c3af54] fs: update todo message Author: Yagiz Nizipli Date: Tue Nov 1 09:51:49 2022 -0400 2 files changed, 2 insertions(+), 2 deletions(-) [main d1b8cb5ca8] fs: protect fs.watch from monkeypatches Author: Yagiz Nizipli Date: Tue Nov 1 09:52:19 2022 -0400 1 file changed, 14 insertions(+), 9 deletions(-) ✔ Patches applied There are 2 commits in the PR. Attempting autorebase. Rebasing (2/4)https://github.com/nodejs/node/actions/runs/3371785169 |
anonrig
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in a5c6f3e |
RafaelGSS
pushed a commit
that referenced
this pull request
Nov 1, 2022
PR-URL: #45265 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Moshe Atlow <[email protected]>
|
Yes @RafaelGSS. This was an educational experience for me. Sorry for the disturbance (and future ones) I've caused. It seems squash gets the first commit title. I thought it was the pull requests title. In this scenario, does the pull request require |
lucshi
pushed a commit
to lucshi/node
that referenced
this pull request
Nov 9, 2022
PR-URL: nodejs#45265 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Moshe Atlow <[email protected]>
RafaelGSS
pushed a commit
that referenced
this pull request
Nov 10, 2022
PR-URL: #45265 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Moshe Atlow <[email protected]>
Merged
danielleadams
pushed a commit
that referenced
this pull request
Dec 30, 2022
PR-URL: #45265 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Moshe Atlow <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Dec 30, 2022
PR-URL: #45265 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Moshe Atlow <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Jan 3, 2023
PR-URL: #45265 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Moshe Atlow <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up on comments from #45098
CC @nodejs/fs