Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

meta: update AUTHORS #45238

Merged
merged 2 commits into from
Oct 30, 2022
Merged

meta: update AUTHORS #45238

merged 2 commits into from
Oct 30, 2022

Conversation

nodejs-github-bot
Copy link
Collaborator

Here are some new additions to the AUTHORS file. This is an automatically generated PR by the authors.yml GitHub Action, which runs tools/update-authors.mjs.

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Oct 30, 2022
@aduh95
Copy link
Contributor

aduh95 commented Oct 30, 2022 

Author name already in AUTHORS file. Possible duplicate:
  Vladimir Morozov <[email protected]>
Author name already in AUTHORS file. Possible duplicate:
  Andreas Schwab <[email protected]>
Author name already in AUTHORS file. Possible duplicate:
  Brian Muenzenmeyer <[email protected]>
Author name already in AUTHORS file. Possible duplicate:
  Steven R. Loomis <[email protected]>

https://github.com/nodejs/node/actions/runs/3353516963/jobs/5556361773#step:3:6

@Trott
Copy link
Member

Trott commented Oct 30, 2022 

Author name already in AUTHORS file. Possible duplicate:
  Vladimir Morozov <[email protected]>
Author name already in AUTHORS file. Possible duplicate:
  Andreas Schwab <[email protected]>
Author name already in AUTHORS file. Possible duplicate:
  Brian Muenzenmeyer <[email protected]>
Author name already in AUTHORS file. Possible duplicate:
  Steven R. Loomis <[email protected]>

https://github.com/nodejs/node/actions/runs/3353516963/jobs/5556361773#step:3:6

Confirmed that they were all duplicates (by looking at commits in the log file for both email addresses for each name, going to the PR-URL, and confirming that it was the same GitHub username for both email addresses), added .mailmap entries, and reran tools/update-authors.mjs. Should be ready to land.

@Trott Trott added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Oct 30, 2022
@Trott Trott added the fast-track PRs that do not need to wait for 48 hours to land. label Oct 30, 2022
@github-actions
Copy link
Contributor

Fast-track has been requested by @Trott. Please 👍 to approve.

@Trott Trott added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 30, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 30, 2022
@nodejs-github-bot nodejs-github-bot merged commit 2364ed7 into main Oct 30, 2022
@nodejs-github-bot
Copy link
Collaborator Author

Landed in 2364ed7

@nodejs-github-bot nodejs-github-bot deleted the actions/authors-update branch October 30, 2022 15:06
RafaelGSS pushed a commit that referenced this pull request Nov 1, 2022
@nodejs-github-bot @RafaelGSS
meta: update AUTHORS
65f3c61 
PR-URL: #45238
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Nov 1, 2022
Merged
RafaelGSS pushed a commit that referenced this pull request Nov 10, 2022
@nodejs-github-bot @RafaelGSS
meta: update AUTHORS
b41b5ba 
PR-URL: #45238
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@nodejs-github-bot @danielleadams
meta: update AUTHORS
74dc993 
PR-URL: #45238
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@danielleadams danielleadams mentioned this pull request Dec 30, 2022
Merged
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@nodejs-github-bot @danielleadams
meta: update AUTHORS
8bcc87c 
PR-URL: #45238
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
@nodejs-github-bot @danielleadams
meta: update AUTHORS
d7fe2ea 
PR-URL: #45238
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@Trott Trott Trott approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. fast-track PRs that do not need to wait for 48 hours to land. meta Issues and PRs related to the general management of the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nodejs-github-bot @aduh95 @Trott @lpinca