Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: workaround for node-core-utils #45199

Merged
merged 1 commit into from
Oct 28, 2022
Merged

build: workaround for node-core-utils #45199

merged 1 commit into from
Oct 28, 2022

Conversation

gengjiawen
Copy link
Member

@gengjiawen gengjiawen requested a review from aduh95 October 27, 2022 03:34
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/actions

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Oct 27, 2022
@gengjiawen gengjiawen added the fast-track PRs that do not need to wait for 48 hours to land. label Oct 27, 2022
@github-actions
Copy link
Contributor

Fast-track has been requested by @gengjiawen. Please 👍 to approve.

aduh95
aduh95 reviewed Oct 27, 2022
View reviewed changes
Copy link
Contributor

@aduh95 aduh95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe change the value of NODE_VERSION instead? Otherwise it's pretty confusing:

node/.github/workflows/auto-start-ci.yml

Lines 13 to 14 in 5e2aeae

env:
NODE_VERSION: lts/*

@gengjiawen gengjiawen added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 27, 2022
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Oct 27, 2022
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/45199
✔  Done loading data for nodejs/node/pull/45199
----------------------------------- PR info ------------------------------------
Title      build: workaround for node-core-utils (#45199)
Author     Jiawen Geng  (@gengjiawen)
Branch     gengjiawen:fix/node_fetch_fix -> nodejs:main
Labels     meta, fast-track
Commits    1
 - build: workaround for node-core-utils
Committers 1
 - Jiawen Geng 
PR-URL: https://github.com/nodejs/node/pull/45199
Reviewed-By: Antoine du Hamel 
Reviewed-By: Richard Lau 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/45199
Reviewed-By: Antoine du Hamel 
Reviewed-By: Richard Lau 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Thu, 27 Oct 2022 03:34:38 GMT
   ✔  Approvals: 2
   ✔  - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/45199#pullrequestreview-1157558430
   ✔  - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/45199#pullrequestreview-1158015502
   ℹ  This PR is being fast-tracked
   ✖  The fast-track request requires at least two collaborators' approvals (👍).
   ✔  Last GitHub CI successful
   ℹ  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/3336617372

@gengjiawen gengjiawen removed the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Oct 27, 2022
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Oct 27, 2022
@aduh95
Copy link
Contributor

aduh95 commented Oct 27, 2022

I wonder if a better workaround would be to set NODE_OPTIONS to --dns-result-order=ipv4first since that seems to be what's the causing the issue according to the linked issue.

@gengjiawen gengjiawen added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Oct 28, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 28, 2022
@nodejs-github-bot nodejs-github-bot merged commit b2a6083 into nodejs:main Oct 28, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in b2a6083

@aduh95 aduh95 removed the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Oct 28, 2022
@gengjiawen gengjiawen deleted the fix/node_fetch_fix branch October 28, 2022 01:15
RafaelGSS pushed a commit that referenced this pull request Nov 1, 2022
@gengjiawen @RafaelGSS
build: workaround for node-core-utils
ca73a24 
PR-URL: #45199
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Nov 1, 2022
Merged
RafaelGSS pushed a commit that referenced this pull request Nov 10, 2022
@gengjiawen @RafaelGSS
build: workaround for node-core-utils
75e0a2d 
PR-URL: #45199
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@gengjiawen @danielleadams
build: workaround for node-core-utils
e05b34f 
PR-URL: #45199
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
@danielleadams danielleadams mentioned this pull request Dec 30, 2022
Merged
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@gengjiawen @danielleadams
build: workaround for node-core-utils
aa5c4e4 
PR-URL: #45199
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
@gengjiawen @danielleadams
build: workaround for node-core-utils
473a879 
PR-URL: #45199
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juanarbol juanarbol juanarbol approved these changes

@aduh95 aduh95 aduh95 approved these changes

@richardlau richardlau richardlau approved these changes

@anonrig anonrig anonrig approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. meta Issues and PRs related to the general management of the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@gengjiawen @nodejs-github-bot @aduh95 @anonrig @richardlau @juanarbol