-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Remove mention of --experimental-async-stack-tagging-api
flag
#45051
Merged
nodejs-github-bot
merged 1 commit into
nodejs:main
from
szuend:remove-async-stack-tagging-api
Oct 18, 2022
Merged
test: Remove mention of --experimental-async-stack-tagging-api
flag
#45051
nodejs-github-bot
merged 1 commit into
nodejs:main
from
szuend:remove-async-stack-tagging-api
Oct 18, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
PRs that need a full CI run.
test
Issues and PRs related to the tests.
labels
Oct 18, 2022
szuend
force-pushed
the
remove-async-stack-tagging-api
branch
from
October 18, 2022 08:55
8630231
to
0a3e3e7
Compare
targos
approved these changes
Oct 18, 2022
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Oct 18, 2022
aduh95
changed the title
test: Remove mention of
test: Remove mention of Oct 18, 2022
--experimanl-async-stack-tagging-api
flag--experimental-async-stack-tagging-api
flag
aduh95
approved these changes
Oct 18, 2022
aduh95
added
fast-track
PRs that do not need to wait for 48 hours to land.
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
labels
Oct 18, 2022
Fast-track has been requested by @aduh95. Please 👍 to approve. |
aduh95
added
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Oct 18, 2022
nodejs-github-bot
removed
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Oct 18, 2022
Landed in 90044f5 |
RafaelGSS
pushed a commit
that referenced
this pull request
Nov 1, 2022
PR-URL: #45051 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
Merged
RafaelGSS
pushed a commit
that referenced
this pull request
Nov 10, 2022
PR-URL: #45051 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Dec 30, 2022
PR-URL: #45051 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Dec 30, 2022
PR-URL: #45051 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Jan 3, 2023
PR-URL: #45051 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
fast-track
PRs that do not need to wait for 48 hours to land.
needs-ci
PRs that need a full CI run.
test
Issues and PRs related to the tests.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The flag was enabled by default with V10.6 (https://crrev.com/c/3809692) and we plan to remove the flag now in time for V8 10.9.