Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: do not use the set-output command in workflows #45024

Merged
merged 1 commit into from
Oct 19, 2022
Merged

tools: do not use the set-output command in workflows #45024

merged 1 commit into from
Oct 19, 2022

Conversation

lpinca
Copy link
Member

@lpinca lpinca commented Oct 16, 2022 •
edited
Loading

The set-output command is deprecated. Use the GITHUB_OUTPUT environment file.

Refs: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/actions

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Oct 16, 2022
@targos
Copy link
Member

targos commented Oct 16, 2022

We could use the new GITHUB_OUTPUT: https://docs.github.com/en/actions/using-workflows/workflow-commands-for-github-actions#setting-an-output-parameter

@lpinca lpinca force-pushed the use/environment-files branch from 590ada3 to 272603a Compare October 16, 2022 08:34
@lpinca
Copy link
Member Author

lpinca commented Oct 16, 2022

Done, PTAL.

anonrig
anonrig approved these changes Oct 16, 2022
View reviewed changes
Copy link
Member

@anonrig anonrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

bnb
bnb approved these changes Oct 16, 2022
View reviewed changes
Copy link
Contributor

@bnb bnb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, presuming none of these will ever run on self-hosted runners,

@lpinca lpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 19, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 19, 2022
@nodejs-github-bot nodejs-github-bot merged commit 7ed44db into nodejs:main Oct 19, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in 7ed44db

@lpinca lpinca deleted the use/environment-files branch October 20, 2022 06:17
RafaelGSS pushed a commit that referenced this pull request Nov 1, 2022
@lpinca @RafaelGSS
tools: do not use the set-output command in workflows
7cd85b6 
The `set-output` command is deprecated. Use the `GITHUB_OUTPUT`
environment file.

Refs: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
PR-URL: #45024
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Tierney Cyren <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Nov 1, 2022
Merged
RafaelGSS pushed a commit that referenced this pull request Nov 10, 2022
@lpinca @RafaelGSS
tools: do not use the set-output command in workflows
a70b276 
The `set-output` command is deprecated. Use the `GITHUB_OUTPUT`
environment file.

Refs: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
PR-URL: #45024
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Tierney Cyren <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: James M Snell <[email protected]>
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@lpinca @danielleadams
tools: do not use the set-output command in workflows
aaf8a70 
The `set-output` command is deprecated. Use the `GITHUB_OUTPUT`
environment file.

Refs: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
PR-URL: #45024
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Tierney Cyren <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@danielleadams danielleadams mentioned this pull request Dec 30, 2022
Merged
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@lpinca @danielleadams
tools: do not use the set-output command in workflows
3201265 
The `set-output` command is deprecated. Use the `GITHUB_OUTPUT`
environment file.

Refs: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
PR-URL: #45024
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Tierney Cyren <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: James M Snell <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
@lpinca @danielleadams
tools: do not use the set-output command in workflows
ee78e2e 
The `set-output` command is deprecated. Use the `GITHUB_OUTPUT`
environment file.

Refs: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
PR-URL: #45024
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Tierney Cyren <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RaisinTen RaisinTen RaisinTen approved these changes

@richardlau richardlau richardlau approved these changes

@anonrig anonrig anonrig approved these changes

@Trott Trott Trott approved these changes

@bnb bnb bnb approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
meta Issues and PRs related to the general management of the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@lpinca @nodejs-github-bot @targos @jasnell @bnb @Trott @anonrig @richardlau @RaisinTen