doc: fix undici version in changelog #44982
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The last PR to update the undici version in V18 and V16 had two commits. Once to update to 5.9.1 and one to upodate to 5.10.0. Unfortunately it looks like when squashed the commit indicates 5.9.1 which was reported as confusing in the changelogs. I don't think we can necessarily change the commit message in the commit, but I think having the changelogs indicate the correct version makes sense even without that change. This PR updates the version in the two changelogs. Signed-off-by: Michael Dawson <[email protected]>
|
I think the problem was that since the bot was used to land the PR it squashed the two commits and kept the message from the first one. I'm not sure what we can do to avoid this from happening in the future. I guess in this case it probably should have been tagged so that it would not have been squashed. If anybody has any other suggestions of what we might do to handle this in the future I think this PR is a reasonable place to discuss them. |
lpinca
approved these changes
Oct 12, 2022
BethGriggs
approved these changes
Oct 12, 2022
Maybe make the tools workflow add |
anonrig
approved these changes
Oct 14, 2022
@Trott since I think you created the action in the first place does that seem reasonable to you? |
mhdawson
added a commit
that referenced
this pull request
Oct 14, 2022
The last PR to update the undici version in V18 and V16 had two commits. Once to update to 5.9.1 and one to upodate to 5.10.0. Unfortunately it looks like when squashed the commit indicates 5.9.1 which was reported as confusing in the changelogs. I don't think we can necessarily change the commit message in the commit, but I think having the changelogs indicate the correct version makes sense even without that change. This PR updates the version in the two changelogs. Signed-off-by: Michael Dawson <[email protected]> PR-URL: #44982 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
|
Landed in 10f93679c531Landed in 10f9367 |
I think so, but I haven't tested that or anything..... |
RafaelGSS
pushed a commit
that referenced
this pull request
Nov 1, 2022
The last PR to update the undici version in V18 and V16 had two commits. Once to update to 5.9.1 and one to upodate to 5.10.0. Unfortunately it looks like when squashed the commit indicates 5.9.1 which was reported as confusing in the changelogs. I don't think we can necessarily change the commit message in the commit, but I think having the changelogs indicate the correct version makes sense even without that change. This PR updates the version in the two changelogs. Signed-off-by: Michael Dawson <[email protected]> PR-URL: #44982 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
Merged
RafaelGSS
pushed a commit
that referenced
this pull request
Nov 10, 2022
The last PR to update the undici version in V18 and V16 had two commits. Once to update to 5.9.1 and one to upodate to 5.10.0. Unfortunately it looks like when squashed the commit indicates 5.9.1 which was reported as confusing in the changelogs. I don't think we can necessarily change the commit message in the commit, but I think having the changelogs indicate the correct version makes sense even without that change. This PR updates the version in the two changelogs. Signed-off-by: Michael Dawson <[email protected]> PR-URL: #44982 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Dec 30, 2022
The last PR to update the undici version in V18 and V16 had two commits. Once to update to 5.9.1 and one to upodate to 5.10.0. Unfortunately it looks like when squashed the commit indicates 5.9.1 which was reported as confusing in the changelogs. I don't think we can necessarily change the commit message in the commit, but I think having the changelogs indicate the correct version makes sense even without that change. This PR updates the version in the two changelogs. Signed-off-by: Michael Dawson <[email protected]> PR-URL: #44982 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Dec 30, 2022
The last PR to update the undici version in V18 and V16 had two commits. Once to update to 5.9.1 and one to upodate to 5.10.0. Unfortunately it looks like when squashed the commit indicates 5.9.1 which was reported as confusing in the changelogs. I don't think we can necessarily change the commit message in the commit, but I think having the changelogs indicate the correct version makes sense even without that change. This PR updates the version in the two changelogs. Signed-off-by: Michael Dawson <[email protected]> PR-URL: #44982 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Jan 3, 2023
The last PR to update the undici version in V18 and V16 had two commits. Once to update to 5.9.1 and one to upodate to 5.10.0. Unfortunately it looks like when squashed the commit indicates 5.9.1 which was reported as confusing in the changelogs. I don't think we can necessarily change the commit message in the commit, but I think having the changelogs indicate the correct version makes sense even without that change. This PR updates the version in the two changelogs. Signed-off-by: Michael Dawson <[email protected]> PR-URL: #44982 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The last PR to update the undici version in V18 and V16 had two commits. One to update to 5.9.1 and one to upodate to 5.10.0. Unfortunately it looks like
when squashed the commit indicates 5.9.1 which was reported as confusing in the changelogs.
I don't think we can necessarily change the commit message in the commit, but I think having the
changelogs indicate the correct version makes sense even without that change.
This PR updates the version in the two changelogs.
Signed-off-by: Michael Dawson [email protected]