test: add test to improve coverage in test-http2-compat-serverresponse-write.js #44970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
lpinca
reviewed
Oct 11, 2022
| request.resume(); | ||
| request.on('end', mustCall()); | ||
| request.on('close', mustCall(() => { | ||
| client.close(); |
There was a problem hiding this comment.
Are both this and client.destroy(); below needed? I would keep only one if possible.
There was a problem hiding this comment.
I think is not necessary, just pushed a new commit for that. Thanks
Cesar-M-Diaz
force-pushed
the
test-fix-1
branch
from
0c1dfec to
60dfde0
Compare
github-actions
bot
removed
the
request-ci
|
CI failing is not related to this change. Requesting a CI run again |
github-actions
bot
removed
the
request-ci
|
@lpinca PTAL |
|
@Cesar-M-Diaz it seems good to me but I'm not sure I understand what is tested in particular. Can you please add a comment or clarify how coverage is increased with a link or an image? Thanks. |
|
@lpinca Im covering this statement with the test |
lpinca
approved these changes
Oct 14, 2022
|
Thanks. |
juanarbol
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 4264b19 |
This was referenced Oct 18, 2022
RafaelGSS
pushed a commit
that referenced
this pull request
Nov 1, 2022
PR-URL: #44970 Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Adrian Estrada <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Merged
RafaelGSS
pushed a commit
that referenced
this pull request
Nov 10, 2022
PR-URL: #44970 Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Adrian Estrada <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Dec 30, 2022
PR-URL: #44970 Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Adrian Estrada <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Dec 30, 2022
PR-URL: #44970 Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Adrian Estrada <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Jan 3, 2023
PR-URL: #44970 Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Adrian Estrada <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a test to complement the test coverage on this file test-http2-compat-serverresponse-write.js