Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: improve test coverage in test-child-process-spawn-argv0.js #44955

Merged
merged 1 commit into from
Oct 14, 2022
Merged

test: improve test coverage in test-child-process-spawn-argv0.js #44955

merged 1 commit into from
Oct 14, 2022

Conversation

juanarbol
Copy link
Member

No description provided.

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Oct 10, 2022
@juanarbol juanarbol added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 14, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 14, 2022
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47274/

@juanarbol juanarbol added commit-queue Add this label to land a pull request using GitHub Actions. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Oct 14, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 14, 2022
@nodejs-github-bot nodejs-github-bot merged commit 386d761 into nodejs:main Oct 14, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in 386d761

@juanarbol juanarbol deleted the juan/cp-argv0-test-improvement branch October 24, 2022 13:48
RafaelGSS pushed a commit that referenced this pull request Nov 1, 2022
@juanarbol @RafaelGSS
test: improve test coverage in test-child-process-spawn-argv0.js
02a6a14 
PR-URL: #44955
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Nov 1, 2022
Merged
RafaelGSS pushed a commit that referenced this pull request Nov 10, 2022
@juanarbol @RafaelGSS
test: improve test coverage in test-child-process-spawn-argv0.js
4825786 
PR-URL: #44955
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@juanarbol @danielleadams
test: improve test coverage in test-child-process-spawn-argv0.js
d980eec 
PR-URL: #44955
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@danielleadams danielleadams mentioned this pull request Dec 30, 2022
Merged
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@juanarbol @danielleadams
test: improve test coverage in test-child-process-spawn-argv0.js
43f4ed5 
PR-URL: #44955
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
@juanarbol @danielleadams
test: improve test coverage in test-child-process-spawn-argv0.js
dfc2419 
PR-URL: #44955
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joyeecheung joyeecheung joyeecheung approved these changes

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@juanarbol @nodejs-github-bot @lpinca @cjihrig @joyeecheung