Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: use large runner for test-asan workflow #44908

Closed
wants to merge 1 commit into from

Conversation

targos
Copy link
Member

@targos targos commented Oct 7, 2022

No description provided.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/actions

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Oct 7, 2022
@tniessen
Copy link
Member

tniessen commented Oct 7, 2022

Is there some context here? Is this additional infra that the build team has to maintain? Does it scale to parallel jobs as default runners do? Is this likely to fix some of the flaky tests?

@tniessen tniessen added the build Issues and PRs related to build files or the CI. label Oct 7, 2022
@Trott
Copy link
Member

Trott commented Oct 7, 2022

It appears that the larger runners can take some time to be available. This PR has been waiting for one for hours now.

image

@targos targos added the blocked PRs that are blocked by other issues or PRs. label Oct 8, 2022
Copy link
Member

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but let's make sure the delay isn't too onerous before landing

@bnb
Copy link
Contributor

bnb commented Oct 10, 2022

I believe how this works (I could definitely be wrong) is that we would actually need to get XL runners dedicated from GitHub to us - normally this is something a company would pay for, and they're not included in GitHub Team or Enterprise (AFAIK). This explains why the test-asan Action is not starting - it's waiting for a machine that isn't going to be allocated (until we get the correct entitlement).

I tried one avenue and got a gentle but firm no (I can give more detail on that no privately to TSC members if that's helpful), trying another now but ngl I wouldn't be surprised if the answer is also no there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked PRs that are blocked by other issues or PRs. build Issues and PRs related to build files or the CI. meta Issues and PRs related to the general management of the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants