test: shorten path for bogus socket

[Trott]

This (hopefully) fixes CI failures for test-net-pipe-connect-errors on Raspberry Pi
devices.

[Trott]

R=@jbergstroem

[Trott]

CI: https://ci.nodejs.org/job/node-test-commit/1574/

[jbergstroem]

LGTM if ci is green. The 'real' fix here is passing a different temporary path which is in the works.

[Trott]

@jbergstroem CI is green (well, yellow, because one known-flaky test, but you know, green-ish). I'll leave it up to you if you want to let this sit for a bit so others can comment or if you want to expedite a merge on the grounds that CI won't be green until this lands.

[jbergstroem]

I'd say merge. It fixes current state and won't be in the way for the long term solution.

[jasnell]

LGTM

[jasnell]

Landed in bfa925f

[MylesBorins]

I think that this commit is responsible for failures that we are currently seeing on v5.4.x in CI.

I am a bit flabbergasted as to why this causes failures only on a specific ARM machine, and only on v5.x and not master, but perhaps it is something to do with the way a specific semver minor or semver major change is working.

It seems like the semantics of this fix might be relying on a SemverMajor change that is sitting on master, meaning that it should likely hold off until 6.0 to land.

edit: it appears that the CI on reverting this commit is causing other stuff on ARM to fail (probably what was originally being fixed)

https://ci.nodejs.org/job/node-test-binary-arm/RUN_SUBSET=2,nodes=pi2-raspbian-wheezy/545/tapTestReport/test.tap-81/

[MylesBorins]

It does not appear that reverting the commit helps with anything. In fact it would appear that more things are failing without it. I am at a bit of a loss

[jbergstroem]

Just a fyi: while tests were running the environment variable node_test_dir wasn't properly set (which it is now).

[MylesBorins]

After discussion with @mhdawson I have opted to back this commit out of the staging branch for the time being. It appears that this commit relies on enhancements found in #3325, specifically the removal of the env var NODE_COMMON_PIPE and the introduction of the NODE_TMP_DIR

Until a decision is made regarding #3325 I'm going to hold off

[jbergstroem]

I saw this commit more as a temporary patch to fix build issues between #3325 landed and NODE_TMP_DIR properly being in place in jenkins. #3325 supersedes this since it doesn't take NODE_COMMON_PIPE into regard any longer, rather sets it relative to NODE_TMP_DIR.

• pre test: make temp path customizable #3325 - no NODE_COMMON_PIPE: /home/iojs/build/workspace/node-test-commit-linux/nodes/centos7-64/test/tmp.0/node.sock
• pre test: make temp path customizable #3325 - with NODE_COMMON_PIPE (set through env): /home/iojs/node.sock
• post test: make temp path customizable #3325 - using NODE_TMP_DIR (set through env): /home/iojs/node-tmp/tmp.0/node.sock

The problem that #3325 set to solve was that NODE_COMMON_PIPE was being used by multiple test runners if the test suite was running in parallel.

[MylesBorins]

so it would seem to me that an appropriate solution would be to backport #3325 and stop using NODE_COMMON_PIPE everywhere to avoid parallel tests stepping on each others feet

[jbergstroem]

@thealphanerd Yes, that'd be my suggested solution too. The problem with CI is that we have so many versions of Makefile, different ways of building, releasing and testing node between all branches which makes it hard to have "one true way" of doing something. That's why we can't rely on flags or makefile directives and most often have to do env injections with fallbacks.

Moving back to this PR it should be harmless to merge -- we still have NODE_COMMON_PIPE set on all vm's and will for the foreseeable future.

[MylesBorins]

@mhdawson do you think this is ready to come back in?

[mhdawson]

@thealphanerd the key issue is if all the dependent pieces landed. It looks like #3325 has landed so its probably ok if that was the only one required.

[MylesBorins]

thanks for chiming in @mhdawson

I will be including this in the next v4.4.0 rc. Please let us know if there is any weirdness on your end due to this