doc: enrich test commands with executable #44347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
build
tony-go
commented
Aug 22, 2022
aduh95
reviewed
Aug 23, 2022
aduh95
reviewed
Aug 24, 2022
RaisinTen
reviewed
Aug 24, 2022
RaisinTen
approved these changes
Aug 25, 2022
There was a problem hiding this comment.
LGTM, would be nice if you could also include the reasoning (#44347 (comment)) in the description
jasnell
approved these changes
Aug 28, 2022
|
@RaisinTen I finally updated the doc, could PTAL ^^ |
richardlau
reviewed
Feb 4, 2023
|
Finally, remove the python exec from examples and add a note for windows. |
RaisinTen
added
the
author ready
richardlau
approved these changes
Feb 6, 2023
RaisinTen
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 2dacd07 |
MylesBorins
pushed a commit
that referenced
this pull request
Feb 18, 2023
PR-URL: #44347 Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Richard Lau <[email protected]>
Merged
danielleadams
pushed a commit
that referenced
this pull request
Apr 11, 2023
PR-URL: #44347 Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Richard Lau <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey 👋
A tiny pull request to enrich test commands in the documentation.
cc @arkerone