benchmark: forcefully close processes #43557
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CC: @nodejs/build |
nodejs-github-bot
added
the
benchmark
BridgeAR
reviewed
Jun 25, 2022
FWIW the benchmark machines in the CI are baremetal machines (donated by Intel for the purposes of benchmark work). The only load on the machines should be Jenkins and the code excuted by the benchmark job. |
|
Yes, I tested it, it's not a load problem. |
BridgeAR
approved these changes
Jun 25, 2022
rvagg
approved these changes
Jun 27, 2022
ShogunPanda
force-pushed
the
force-close-benchmarks
branch
from
ca74cb6 to
fe5dc88
Compare
ShogunPanda
added a commit
that referenced
this pull request
Jun 27, 2022
PR-URL: #43557 Fixes: nodejs/build#2968 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Rod Vagg <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
|
Landed in 684e107 |
targos
pushed a commit
that referenced
this pull request
Jul 12, 2022
PR-URL: #43557 Fixes: nodejs/build#2968 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Rod Vagg <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
targos
pushed a commit
that referenced
this pull request
Jul 20, 2022
PR-URL: #43557 Fixes: nodejs/build#2968 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Rod Vagg <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
targos
pushed a commit
that referenced
this pull request
Jul 31, 2022
PR-URL: #43557 Fixes: nodejs/build#2968 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Rod Vagg <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
guangwong
pushed a commit
to noslate-project/node
that referenced
this pull request
Oct 10, 2022
PR-URL: nodejs/node#43557 Fixes: nodejs/build#2968 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Rod Vagg <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes sure a benchmark always exit after reporting results.
The timer is created in order to allow the process to exit normally.
This solves situations in which some resources are wrongfully reported as active (like HTTP sockets closed in a bad way by wrk) and prevent the benchmarks to continue.
Fixes: nodejs/build#2968