Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

meta: update AUTHORS #43480

Merged
merged 2 commits into from
Jun 19, 2022
Merged

meta: update AUTHORS #43480

merged 2 commits into from
Jun 19, 2022

Conversation

nodejs-github-bot
Copy link
Collaborator

Here are some new additions to the AUTHORS file. This is an automatically generated PR by the authors.yml GitHub Action, which runs tools/update-authors.mjs.

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Jun 19, 2022
@Trott Trott added commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. fast-track PRs that do not need to wait for 48 hours to land. labels Jun 19, 2022
@github-actions
Copy link
Contributor

Fast-track has been requested by @Trott. Please 👍 to approve.

@F3n67u
Copy link
Member

F3n67u commented Jun 19, 2022

@lpinca Does the "fixup!" in "fixup! meta: update AUTHORS" has special function? I see this notation multiple time but don't know what is mean.

@Trott
Copy link
Member

Trott commented Jun 19, 2022

@lpinca Does the "fixup!" in "fixup! meta: update AUTHORS" has special function? I see this notation multiple time but don't know what is mean.

It's the result of using git commit --fixup. In the CLI, it makes it possible to use git rebase -i --autosquash. https://fle.github.io/git-tip-keep-your-branch-clean-with-fixup-and-autosquash.html

Within our PRs and commit queue, it also indicates that the commit should be squashed into the previous commit rather than kept separate when the PR lands.

@F3n67u
Copy link
Member

F3n67u commented Jun 19, 2022

@lpinca Does the "fixup!" in "fixup! meta: update AUTHORS" has special function? I see this notation multiple time but don't know what is mean.

It's the result of using git commit --fixup. In the CLI, it makes it possible to use git rebase -i --autosquash. https://fle.github.io/git-tip-keep-your-branch-clean-with-fixup-and-autosquash.html

Within our PRs and commit queue, it also indicates that the commit should be squashed into the previous commit rather than kept separate when the PR lands.

Thanks for the info. I learn something from you.

@Trott Trott added the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 19, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 19, 2022
@nodejs-github-bot nodejs-github-bot merged commit 028a0a3 into main Jun 19, 2022
@nodejs-github-bot
Copy link
Collaborator Author

Landed in 028a0a3

@Trott Trott deleted the actions/authors-update branch June 19, 2022 22:40
targos pushed a commit that referenced this pull request Jul 12, 2022
@nodejs-github-bot @targos
meta: update AUTHORS
b9204c9 
PR-URL: #43480
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
@targos targos mentioned this pull request Jul 12, 2022
Merged
targos pushed a commit that referenced this pull request Jul 18, 2022
@nodejs-github-bot @targos
meta: update AUTHORS
6bdd0f5 
PR-URL: #43480
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
targos pushed a commit that referenced this pull request Jul 31, 2022
@nodejs-github-bot @targos
meta: update AUTHORS
3760490 
PR-URL: #43480
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
@targos targos mentioned this pull request Aug 3, 2022
Merged
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
@nodejs-github-bot @guangwong
meta: update AUTHORS
a8b89ee 
PR-URL: nodejs/node#43480
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tniessen tniessen tniessen approved these changes

@lpinca lpinca lpinca approved these changes

@Trott Trott Trott approved these changes

Assignees
No one assigned
Labels
commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. fast-track PRs that do not need to wait for 48 hours to land. meta Issues and PRs related to the general management of the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nodejs-github-bot @F3n67u @Trott @lpinca @tniessen