build: clarify missing clang-format tool #42762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
build
tniessen
force-pushed
the
makefile-clang-format-is-not-clang-format
branch
from
9fe4a40 to
671b6dc
Compare
tniessen
changed the title
tniessen
added
fast-track
|
Fast-track has been requested by @tniessen. Please 👍 to approve. |
RaisinTen
approved these changes
Apr 17, 2022
Trott
reviewed
Apr 17, 2022
Trott
approved these changes
Apr 17, 2022
Mesteery
approved these changes
Apr 17, 2022
Co-authored-by: Rich Trott <[email protected]>
tniessen
force-pushed
the
makefile-clang-format-is-not-clang-format
branch
from
4e3628a to
88b6f6a
Compare
lpinca
approved these changes
Apr 18, 2022
tniessen
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/42762 ✔ Done loading data for nodejs/node/pull/42762 ----------------------------------- PR info ------------------------------------ Title build: clarify missing clang-format tool (#42762) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch tniessen:makefile-clang-format-is-not-clang-format -> nodejs:master Labels build, fast-track Commits 1 - build: clarify missing clang-format tool Committers 1 - Tobias Nießen PR-URL: https://github.com/nodejs/node/pull/42762 Reviewed-By: Darshan Sen Reviewed-By: Rich Trott Reviewed-By: Mestery Reviewed-By: Luigi Pinca ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/42762 Reviewed-By: Darshan Sen Reviewed-By: Rich Trott Reviewed-By: Mestery Reviewed-By: Luigi Pinca -------------------------------------------------------------------------------- ℹ This PR was created on Sun, 17 Apr 2022 11:36:45 GMT ✔ Approvals: 4 ✔ - Darshan Sen (@RaisinTen) (TSC): https://github.com/nodejs/node/pull/42762#pullrequestreview-943939663 ✔ - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/42762#pullrequestreview-943954938 ✔ - Mestery (@Mesteery): https://github.com/nodejs/node/pull/42762#pullrequestreview-943982857 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/42762#pullrequestreview-944122927 ℹ This PR is being fast-tracked ✔ Last GitHub CI successful ✖ No Jenkins CI runs detected -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/2183248078 |
github-actions
bot
removed
the
request-ci
|
I fell for nodejs/TSC#1044, thinking |
tniessen
removed
the
commit-queue-failed
tniessen
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
Commit Queue failed- Loading data for nodejs/node/pull/42762 ✔ Done loading data for nodejs/node/pull/42762 ----------------------------------- PR info ------------------------------------ Title build: clarify missing clang-format tool (#42762) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch tniessen:makefile-clang-format-is-not-clang-format -> nodejs:master Labels build, fast-track Commits 1 - build: clarify missing clang-format tool Committers 1 - Tobias Nießen PR-URL: https://github.com/nodejs/node/pull/42762 Reviewed-By: Darshan Sen Reviewed-By: Rich Trott Reviewed-By: Mestery Reviewed-By: Luigi Pinca ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/42762 Reviewed-By: Darshan Sen Reviewed-By: Rich Trott Reviewed-By: Mestery Reviewed-By: Luigi Pinca -------------------------------------------------------------------------------- ℹ This PR was created on Sun, 17 Apr 2022 11:36:45 GMT ✔ Approvals: 4 ✔ - Darshan Sen (@RaisinTen) (TSC): https://github.com/nodejs/node/pull/42762#pullrequestreview-943939663 ✔ - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/42762#pullrequestreview-943954938 ✔ - Mestery (@Mesteery): https://github.com/nodejs/node/pull/42762#pullrequestreview-943982857 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/42762#pullrequestreview-944122927 ℹ This PR is being fast-tracked ✔ Last GitHub CI successful ℹ Last Full PR CI on 2022-04-18T14:09:36Z: https://ci.nodejs.org/job/node-test-pull-request/43555/ - Querying data for job/node-test-pull-request/43555/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/master up to date... From https://github.com/nodejs/node * branch master -> FETCH_HEAD ✔ origin/master is now up-to-date - Downloading patch for 42762 From https://github.com/nodejs/node * branch refs/pull/42762/merge -> FETCH_HEAD ✔ Fetched commits as 3347361713b4..88b6f6a0806b -------------------------------------------------------------------------------- [master fdfefcdcfc] build: clarify missing clang-format tool Author: Tobias Nießen Date: Sun Apr 17 13:34:31 2022 +0200 1 file changed, 1 insertion(+), 1 deletion(-) ✔ Patches applied -------------------------------------------------------------------------------- --------------------------------- New Message ---------------------------------- build: clarify missing clang-format toolhttps://github.com/nodejs/node/actions/runs/2184865680 |
nodejs-github-bot
added
the
commit-queue-failed
This was referenced Apr 19, 2022
jasnell
approved these changes
Apr 20, 2022
22 tasks
RaisinTen
added
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/42762 ✔ Done loading data for nodejs/node/pull/42762 ----------------------------------- PR info ------------------------------------ Title build: clarify missing clang-format tool (#42762) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch tniessen:makefile-clang-format-is-not-clang-format -> nodejs:master Labels build, needs-ci Commits 1 - build: clarify missing clang-format tool Committers 1 - Tobias Nießen PR-URL: https://github.com/nodejs/node/pull/42762 Reviewed-By: Darshan Sen Reviewed-By: Rich Trott Reviewed-By: Mestery Reviewed-By: Luigi Pinca Reviewed-By: James M Snell ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/42762 Reviewed-By: Darshan Sen Reviewed-By: Rich Trott Reviewed-By: Mestery Reviewed-By: Luigi Pinca Reviewed-By: James M Snell -------------------------------------------------------------------------------- ℹ This PR was created on Sun, 17 Apr 2022 11:36:45 GMT ✔ Approvals: 5 ✔ - Darshan Sen (@RaisinTen) (TSC): https://github.com/nodejs/node/pull/42762#pullrequestreview-943939663 ✔ - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/42762#pullrequestreview-943954938 ✔ - Mestery (@Mesteery): https://github.com/nodejs/node/pull/42762#pullrequestreview-943982857 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/42762#pullrequestreview-944122927 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/42762#pullrequestreview-947806244 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2022-04-18T16:32:13Z: https://ci.nodejs.org/job/node-test-pull-request/43555/ - Querying data for job/node-test-pull-request/43555/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/master up to date... From https://github.com/nodejs/node * branch master -> FETCH_HEAD ✔ origin/master is now up-to-date - Downloading patch for 42762 From https://github.com/nodejs/node * branch refs/pull/42762/merge -> FETCH_HEAD ✔ Fetched commits as 61fefe1959a8..88b6f6a0806b -------------------------------------------------------------------------------- [master 2b513c011a] build: clarify missing clang-format tool Author: Tobias Nießen Date: Sun Apr 17 13:34:31 2022 +0200 1 file changed, 1 insertion(+), 1 deletion(-) ✔ Patches applied -------------------------------------------------------------------------------- --------------------------------- New Message ---------------------------------- build: clarify missing clang-format toolhttps://github.com/nodejs/node/actions/runs/2199723145 |
|
It's prevented from landing by nodejs/core-validate-commit#93 but the real issue is nodejs/node-core-utils#602 once again. |
This was referenced Apr 22, 2022
|
nodejs/node-core-utils#632 will hopefully resolve the tooling issue. |
Trott
added
the
author ready
|
Landed in e9f69e8 |
targos
pushed a commit
that referenced
this pull request
Jul 12, 2022
PR-URL: #42762 Co-authored-by: Rich Trott <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Mestery <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
targos
pushed a commit
that referenced
this pull request
Jul 20, 2022
PR-URL: #42762 Co-authored-by: Rich Trott <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Mestery <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
targos
pushed a commit
that referenced
this pull request
Jul 31, 2022
PR-URL: #42762 Co-authored-by: Rich Trott <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Mestery <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
guangwong
pushed a commit
to noslate-project/node
that referenced
this pull request
Oct 10, 2022
PR-URL: nodejs/node#42762 Co-authored-by: Rich Trott <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Mestery <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This confused me when I had to run
make format-cpp. Clarify that it's notclang-formatitself that's missing but rather some tooling around that.