deps: make node-gyp work again on windows #422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @seishun |
|
LGTM if it works but it would be nice if you undid some of the renames. All of the changes have to be upstreamed eventually and the smaller the diff is, the easier. |
|
ditto @bnoordhuis, lgtm but we really need to upstream this |
piscisaureus
force-pushed
the
win-fix-node-gyp
branch
from
e9443f4 to
c71d4a1
Compare
|
@bnoordhuis @rvagg This better? |
|
LGTM |
|
yes, good enough, land this and then one of us needs to take responsibility for proposing an upstream patch to make this permanent and portable |
piscisaureus
force-pushed
the
win-fix-node-gyp
branch
from
c71d4a1 to
ed4f12b
Compare
* Fetch from the correct url. * Link compiled addons with iojs.lib instead of node.lib. * Disable checksum checks for iojs.lib until our website supports them. PR: nodejs#422 Reviewed-by: Ben Noordhuis <[email protected]> Reviewed-by: Rod Vagg <[email protected]>
piscisaureus
force-pushed
the
win-fix-node-gyp
branch
from
ed4f12b to
5de334c
Compare
othiym23
pushed a commit
to npm/node
that referenced
this pull request
Jan 18, 2015
* Fetch from the correct url. * Link compiled addons with iojs.lib instead of node.lib. * Disable checksum checks for iojs.lib until our website supports them. PR: nodejs#422 Reviewed-by: Ben Noordhuis <[email protected]> Reviewed-by: Rod Vagg <[email protected]>
piscisaureus
added a commit
that referenced
this pull request
Jan 18, 2015
* Fetch from the correct url. * Link compiled addons with iojs.lib instead of node.lib. * Disable checksum checks for iojs.lib until our website supports them. PR: #422 Reviewed-by: Ben Noordhuis <[email protected]> Reviewed-by: Rod Vagg <[email protected]>
piscisaureus
added a commit
that referenced
this pull request
Jan 23, 2015
* Fetch from the correct url. * Link compiled addons with iojs.lib instead of node.lib. * Disable checksum checks for iojs.lib until our website supports them. PR: #422 Reviewed-by: Ben Noordhuis <[email protected]> Reviewed-by: Rod Vagg <[email protected]>
othiym23
pushed a commit
to npm/node
that referenced
this pull request
Jan 30, 2015
* Fetch from the correct url. * Link compiled addons with iojs.lib instead of node.lib. * Disable checksum checks for iojs.lib until our website supports them. PR: nodejs#422 Reviewed-by: Ben Noordhuis <[email protected]> Reviewed-by: Rod Vagg <[email protected]>
piscisaureus
added a commit
that referenced
this pull request
Jan 31, 2015
* Fetch from the correct url. * Link compiled addons with iojs.lib instead of node.lib. * Disable checksum checks for iojs.lib until our website supports them. PR: #422 Reviewed-by: Ben Noordhuis <[email protected]> Reviewed-by: Rod Vagg <[email protected]>
othiym23
pushed a commit
to npm/node
that referenced
this pull request
Feb 6, 2015
* Fetch from the correct url. * Link compiled addons with iojs.lib instead of node.lib. * Disable checksum checks for iojs.lib until our website supports them. PR: nodejs#422 Reviewed-by: Ben Noordhuis <[email protected]> Reviewed-by: Rod Vagg <[email protected]>
piscisaureus
added a commit
that referenced
this pull request
Feb 6, 2015
* Fetch from the correct url. * Link compiled addons with iojs.lib instead of node.lib. * Disable checksum checks for iojs.lib until our website supports them. PR: #422 Reviewed-by: Ben Noordhuis <[email protected]> Reviewed-by: Rod Vagg <[email protected]>
othiym23
pushed a commit
to npm/node
that referenced
this pull request
Feb 20, 2015
* Fetch from the correct url. * Link compiled addons with iojs.lib instead of node.lib. * Disable checksum checks for iojs.lib until our website supports them. PR: nodejs#422 Reviewed-by: Ben Noordhuis <[email protected]> Reviewed-by: Rod Vagg <[email protected]>
piscisaureus
added a commit
that referenced
this pull request
Feb 22, 2015
* Fetch from the correct url. * Link compiled addons with iojs.lib instead of node.lib. * Disable checksum checks for iojs.lib until our website supports them. PR: #422 Reviewed-by: Ben Noordhuis <[email protected]> Reviewed-by: Rod Vagg <[email protected]>
This was referenced Oct 25, 2022
This was referenced Jan 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
R=@bnoordhuis
R=@rvagg