tls_wrap: slice buffer properly in ClearOut
#4184
Conversation
Fix incorrect slicing of cleartext buffer in `TLSWrap::ClearOut`. Fix: nodejs#4161
|
cc @nodejs/crypto |
indutny
added
tls
|
CI is green |
| @@ -60,7 +62,7 @@ a.listen(common.PORT, function() { | |||
| }); | |||
| ssl.setEncoding('utf8'); | |||
| ssl.once('data', function(data) { | |||
| assert.equal('hello', data); | |||
| assert.equal(body.toString(), data); | |||
There was a problem hiding this comment.
Is it safe to assume the entire body will always come in one data event?
|
LGTM |
|
Landed in c0cb80e, thank you! |
Fix incorrect slicing of cleartext buffer in `TLSWrap::ClearOut`. Fix: #4161 PR-URL: #4184 Reviewed-By: Brian White <[email protected]>
| ssl.once('data', function(data) { | ||
| assert.equal('hello', data); | ||
| buf += data; | ||
| gotHello = true; | ||
| }); |
There was a problem hiding this comment.
Shouldn't it be on?
Also, is gotHello really necessary?
There was a problem hiding this comment.
Arghh... It should be on indeed. @santigimeno would it be interesting to you to submit a PR with a fix for this?
There was a problem hiding this comment.
gotHello seems to be necessary, but could be replaced with common.mustCall in ssl.on('end', ...)
There was a problem hiding this comment.
I said about gotHello because would the test exit if no end event was received?
Yes, I can send a PR.
There was a problem hiding this comment.
Thank you, @santigimeno . Please don't forget to cc me on that PR ;)
Fix incorrect slicing of cleartext buffer in `TLSWrap::ClearOut`. Fix: #4161 PR-URL: #4184 Reviewed-By: Brian White <[email protected]>
Fix incorrect slicing of cleartext buffer in `TLSWrap::ClearOut`. Fix: #4161 PR-URL: #4184 Reviewed-By: Brian White <[email protected]>
Fix incorrect slicing of cleartext buffer in `TLSWrap::ClearOut`. Fix: #4161 PR-URL: #4184 Reviewed-By: Brian White <[email protected]>
Fix incorrect slicing of cleartext buffer in `TLSWrap::ClearOut`. Fix: nodejs#4161 PR-URL: nodejs#4184 Reviewed-By: Brian White <[email protected]>
Fix incorrect slicing of cleartext buffer in
TLSWrap::ClearOut.Fix: #4161