doc: add registry number for Electron 19 #41814
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
cjihrig
approved these changes
Feb 1, 2022
targos
approved these changes
Feb 1, 2022
|
Fast-track has been requested by @targos. Please 👍 to approve. |
Trott
approved these changes
Feb 1, 2022
richardlau
approved these changes
Feb 1, 2022
Mesteery
approved these changes
Feb 1, 2022
VoltrexKeyva
approved these changes
Feb 1, 2022
tniessen
approved these changes
Feb 1, 2022
VerteDinde
changed the title
bnb
approved these changes
Feb 2, 2022
|
unrelated to the substance of this PR, and absolutely not a blocker: is the history of why we do things like this documented anywhere? I'd really love to have that context :) |
It's all to do with the ABI for addons historically being a single (numerical) identifier and different packagers (Linux distributions) and runtimes (e.g. Electron) have chosen to use different versions of dependencies than we do for the official Node.js binaries. For example several Linux distributions choose to dynamically link against a different OpenSSL version (e.g. #41410); Electron ship different versions of V8. For more context see |
|
Landed in 28989b4 |
targos
pushed a commit
that referenced
this pull request
Feb 3, 2022
PR-URL: #41814 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Mestery <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Tierney Cyren <[email protected]>
VoltrexKeyva
pushed a commit
to VoltrexKeyva/node
that referenced
this pull request
Feb 3, 2022
PR-URL: nodejs#41814 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Mestery <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Tierney Cyren <[email protected]>
ruyadorno
pushed a commit
that referenced
this pull request
Feb 8, 2022
PR-URL: #41814 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Mestery <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Tierney Cyren <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Mar 2, 2022
PR-URL: #41814 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Mestery <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Tierney Cyren <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Mar 3, 2022
PR-URL: #41814 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Mestery <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Tierney Cyren <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Mar 14, 2022
PR-URL: #41814 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Mestery <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Tierney Cyren <[email protected]>
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reserving a new node module version for Electron 19.