Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix typo in MessageChannel test #41746

Merged
merged 1 commit into from
Jan 29, 2022
Merged

test: fix typo in MessageChannel test #41746

merged 1 commit into from
Jan 29, 2022

Conversation

tniessen
Copy link
Member

No description provided.

@tniessen tniessen added the fast-track PRs that do not need to wait for 48 hours to land. label Jan 29, 2022
@github-actions
Copy link
Contributor

Fast-track has been requested by @tniessen. Please 👍 to approve.

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Jan 29, 2022
@tniessen tniessen added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 29, 2022
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed needs-ci PRs that need a full CI run. request-ci Add this label to start a Jenkins CI on a PR. labels Jan 29, 2022
@aduh95
Copy link
Contributor

aduh95 commented Jan 29, 2022

Changes that only affect a comment do not affect the node binary and therefore do not need a full CI to land.

node/doc/contributing/collaborator-guide.md

Lines 208 to 210 in a199387

A passing (green) GitHub Actions CI result is required. A passing (green or
yellow) [Jenkins CI](https://ci.nodejs.org/) is also required if the pull
request contains changes that will affect the `node` binary. This is because

@benjamingr benjamingr added the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 29, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 29, 2022
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/41746
✔  Done loading data for nodejs/node/pull/41746
----------------------------------- PR info ------------------------------------
Title      test: fix typo in MessageChannel test (#41746)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     tniessen:test-typo-msgchannel -> nodejs:master
Labels     test, fast-track, author ready
Commits    1
 - test: fix typo in MessageChannel test
Committers 1
 - GitHub 
PR-URL: https://github.com/nodejs/node/pull/41746
Reviewed-By: Michaël Zasso 
Reviewed-By: Mestery 
Reviewed-By: Antoine du Hamel 
Reviewed-By: Benjamin Gruenbaum 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/41746
Reviewed-By: Michaël Zasso 
Reviewed-By: Mestery 
Reviewed-By: Antoine du Hamel 
Reviewed-By: Benjamin Gruenbaum 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Sat, 29 Jan 2022 12:22:00 GMT
   ✔  Approvals: 4
   ✔  - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/41746#pullrequestreview-866955342
   ✔  - Mestery (@Mesteery): https://github.com/nodejs/node/pull/41746#pullrequestreview-866955586
   ✔  - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/41746#pullrequestreview-866955713
   ✔  - Benjamin Gruenbaum (@benjamingr): https://github.com/nodejs/node/pull/41746#pullrequestreview-866963791
   ℹ  This PR is being fast-tracked
   ✖  GitHub CI is still running
   ✖  No Jenkins CI runs detected
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/1765967304

@nodejs-github-bot nodejs-github-bot added the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Jan 29, 2022
@benjamingr
Copy link
Member

Ah apparently commit queue doesn’t work for changes that don’t require Jenkins CI?

@tniessen tniessen removed the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Jan 29, 2022
@tniessen
Copy link
Member Author

Ah apparently commit queue doesn’t work for changes that don’t require Jenkins CI?

I believe it should, but this PR was marked as needs-ci by the bot so the commit queue might have the same understanding.

@aduh95 aduh95 merged commit 74de555 into nodejs:master Jan 29, 2022
@aduh95
Copy link
Contributor

aduh95 commented Jan 29, 2022

Landed in 74de555.

Ah apparently commit queue doesn’t work for changes that don’t require Jenkins CI?

I believe it should, but this PR was marked as needs-ci by the bot so the commit queue might have the same understanding.

Yes, it's unfortunate but the CQ was built to be extra cautious and is not actually able to differentiate a change in a comment than a change in the code. Landing manually is required there.

Linkgoron pushed a commit to Linkgoron/node that referenced this pull request Jan 31, 2022
@tniessen @Linkgoron
test: fix typo in MessageChannel test
f069e20 
PR-URL: nodejs#41746
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
ruyadorno pushed a commit that referenced this pull request Feb 8, 2022
@tniessen @ruyadorno
test: fix typo in MessageChannel test
abbc06b 
PR-URL: #41746
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
@ruyadorno ruyadorno mentioned this pull request Feb 8, 2022
Merged
danielleadams pushed a commit that referenced this pull request Mar 2, 2022
@tniessen @danielleadams
test: fix typo in MessageChannel test
f002d37 
PR-URL: #41746
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
@danielleadams danielleadams mentioned this pull request Mar 3, 2022
Merged
danielleadams pushed a commit that referenced this pull request Mar 3, 2022
@tniessen @danielleadams
test: fix typo in MessageChannel test
9692e3d 
PR-URL: #41746
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
danielleadams pushed a commit that referenced this pull request Mar 14, 2022
@tniessen @danielleadams
test: fix typo in MessageChannel test
acea61b 
PR-URL: #41746
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mesteery Mesteery Mesteery approved these changes

@RaisinTen RaisinTen RaisinTen approved these changes

@aduh95 aduh95 aduh95 approved these changes

@targos targos targos approved these changes

@benjamingr benjamingr benjamingr approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@tniessen @aduh95 @nodejs-github-bot @benjamingr @targos @RaisinTen @Mesteery