Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: update Mesteery email #41683

Merged
merged 2 commits into from
Jan 29, 2022
Merged

doc: update Mesteery email #41683

merged 2 commits into from
Jan 29, 2022

Conversation

Mesteery
Copy link
Contributor

No description provided.

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Jan 24, 2022
aduh95
aduh95 reviewed Jan 24, 2022
View reviewed changes
README.md Outdated Show resolved Hide resolved
Trott
Trott reviewed Jan 24, 2022
View reviewed changes
README.md
@@ -649,7 +649,7 @@ maintaining the Node.js project.
* [marsonya](https://github.com/marsonya) -
**Akhil Marsonya** <<[email protected]>> (he/him)
* [Mesteery](https://github.com/Mesteery) -
**Mestery** <<mestery@pm.me>>
**Mestery** <<mestery@protonmail.com>> (he/him)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a .mailmap entry for this too so that your entry here matches your entry in AUTHORS and so that you won't show up in AUTHORS twice?

It should look something like this and be placed in the right place in .mailmap alphabetically:

Mestery <[email protected]> <[email protected]>

After you add the entry, you can test it by running tools/update-authors.js. That will update the AUTHORS file and automatically change your pm.me entry to protonmail.com. Then add that version of AUTHORS to this PR> (It may also add new entries to the end of the AUTHORS file. You can delete those or leave them as part of this PR.)

All told, three files need to be updated: README.md, .mailmap, and (via the update script) AUTHORS.

@benjamingr benjamingr added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Jan 29, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 29, 2022
@nodejs-github-bot nodejs-github-bot merged commit 44f8b4f into nodejs:master Jan 29, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in 44f8b4f

Trott added a commit to Trott/io.js that referenced this pull request Jan 29, 2022
@Trott
meta: adjust mailmap/AUTHORS to reflect README change
3b92c86 
Refs: nodejs#41683 (review)
@Trott Trott mentioned this pull request Jan 29, 2022
Merged
nodejs-github-bot pushed a commit that referenced this pull request Jan 29, 2022
@Trott
meta: adjust mailmap/AUTHORS to reflect README change
3e0526c 
Refs: #41683 (review)

PR-URL: #41751
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Linkgoron pushed a commit to Linkgoron/node that referenced this pull request Jan 31, 2022
@Mesteery @Linkgoron
doc: update Mesteery email
9e0f9c4 
PR-URL: nodejs#41683
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Linkgoron pushed a commit to Linkgoron/node that referenced this pull request Jan 31, 2022
@Trott @Linkgoron
meta: adjust mailmap/AUTHORS to reflect README change
128ad41 
Refs: nodejs#41683 (review)

PR-URL: nodejs#41751
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
ruyadorno pushed a commit that referenced this pull request Feb 8, 2022
@Mesteery @ruyadorno
doc: update Mesteery email
26c5efe 
PR-URL: #41683
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
ruyadorno pushed a commit that referenced this pull request Feb 8, 2022
@Trott @ruyadorno
meta: adjust mailmap/AUTHORS to reflect README change
14415fb 
Refs: #41683 (review)

PR-URL: #41751
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
@ruyadorno ruyadorno mentioned this pull request Feb 8, 2022
Merged
danielleadams pushed a commit that referenced this pull request Mar 2, 2022
@Mesteery @danielleadams
doc: update Mesteery email
953779a 
PR-URL: #41683
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
danielleadams pushed a commit that referenced this pull request Mar 2, 2022
@Trott @danielleadams
meta: adjust mailmap/AUTHORS to reflect README change
7ce8f42 
Refs: #41683 (review)

PR-URL: #41751
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
@danielleadams danielleadams mentioned this pull request Mar 3, 2022
Merged
danielleadams pushed a commit that referenced this pull request Mar 3, 2022
@Mesteery @danielleadams
doc: update Mesteery email
e4255d5 
PR-URL: #41683
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
danielleadams pushed a commit that referenced this pull request Mar 3, 2022
@Trott @danielleadams
meta: adjust mailmap/AUTHORS to reflect README change
8aa7a6f 
Refs: #41683 (review)

PR-URL: #41751
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
danielleadams pushed a commit that referenced this pull request Mar 14, 2022
@Mesteery @danielleadams
doc: update Mesteery email
e209f53 
PR-URL: #41683
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
danielleadams pushed a commit that referenced this pull request Mar 14, 2022
@Trott @danielleadams
meta: adjust mailmap/AUTHORS to reflect README change
30e3327 
Refs: #41683 (review)

PR-URL: #41751
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott left review comments

@aduh95 aduh95 aduh95 approved these changes

@lpinca lpinca lpinca approved these changes

@benjamingr benjamingr benjamingr approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Mesteery @nodejs-github-bot @jasnell @Trott @benjamingr @lpinca @aduh95