Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v12.x] tools: update tzdata to 2021a4 #41443

Closed
wants to merge 1 commit into from

Conversation

albertyw
Copy link
Contributor

@albertyw albertyw commented Jan 8, 2022

This updates the time zone database up to 2021a4 for the node v12.x-staging branch, following the documentation at
https://github.com/nodejs/node/blob/master/doc/guides/maintaining-icu.md#time-zone-data.

This is essentially a partial backport of #40658.

Refs: #40658
Refs: nodejs/Release#576

@github-actions github-actions bot added needs-ci PRs that need a full CI run. v12.x labels Jan 8, 2022
@albertyw albertyw closed this Jan 8, 2022
@albertyw albertyw reopened this Jan 14, 2022
@richardlau richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 14, 2022
@richardlau richardlau changed the title tools: update tzdata to 2021a4 [v12.x] tools: update tzdata to 2021a4 Jan 14, 2022
@richardlau richardlau added the notable-change PRs with changes that should be highlighted in changelogs. label Jan 14, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 14, 2022
@nodejs-github-bot
Copy link
Collaborator

This updates the time zone database up to 2021a4 for the node
v12.x-staging branch, following the documentation at
https://github.com/nodejs/node/blob/master/doc/guides/maintaining-icu.md#time-zone-data

This is essentially a backport of nodejs#40658.

Refs: nodejs#40658
Refs: nodejs/Release#576
@richardlau richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 17, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 17, 2022
@nodejs-github-bot
Copy link
Collaborator

@richardlau
Copy link
Member

Quick check for nodejs/Release#576 (comment):
Without this PR:

$ nvm run 12 -p 'new Date("2022-02-25T00:00+0000").toLocaleString("en-US", { timeZone: "Asia/Amman" } )'
Running node v12.22.7 (npm v6.14.15)
2/25/2022, 2:00:00 AM

with this PR:

$ ./node -p 'new Date("2022-02-25T00:00+0000").toLocaleString("en-US", { timeZone: "Asia/Amman" } )'
2/25/2022, 3:00:00 AM

ruyadorno pushed a commit that referenced this pull request Jan 26, 2022
This updates the time zone database up to 2021a4 for the node
v12.x-staging branch, following the documentation at
https://github.com/nodejs/node/blob/master/doc/guides/maintaining-icu.md#time-zone-data

This is essentially a backport of #40658.

Refs: #40658
Refs: nodejs/Release#576

PR-URL: #41443
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Ruy Adorno <[email protected]>
@ruyadorno
Copy link
Member

Landed in d9237c4

@ruyadorno ruyadorno closed this Jan 26, 2022
@ruyadorno ruyadorno mentioned this pull request Jan 26, 2022
@albertyw albertyw deleted the update-tzdata branch August 22, 2022 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ci PRs that need a full CI run. notable-change PRs with changes that should be highlighted in changelogs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants