Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fixup my mailmap entries #41437

Merged
merged 1 commit into from
Jan 11, 2022
Merged

doc: fixup my mailmap entries #41437

merged 1 commit into from
Jan 11, 2022

Conversation

mhdawson
Copy link
Member

@mhdawson mhdawson commented Jan 7, 2022

Fixup the content and order of my mailmap entries. Recent
changelogs have been using my outdated email address.

Signed-off-by: Michael Dawson [email protected]

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Jan 7, 2022
richardlau
richardlau reviewed Jan 7, 2022
View reviewed changes
.mailmap Outdated Show resolved Hide resolved
bnb
bnb requested changes Jan 7, 2022
View reviewed changes
Copy link
Contributor

@bnb bnb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

formally requesting changes based on @richardlau's feedback :)

@mhdawson
Copy link
Member Author

@bnb fixed.

Trott
Trott requested changes Jan 11, 2022
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will result in duplicate entries in AUTHORS.

@Trott
Copy link
Member

Trott commented Jan 11, 2022

This will result in duplicate entries in AUTHORS.

Oh, wait, no it won't. This is good. You probably want to run tools/update-authors.js (and then maybe trim off any new authors it adds at the end--probably best to leave that for a separate PR from the weekly job) to update your entry in AUTHORS. Or you can wait for the automated job to do that, I guess.

@Trott
Copy link
Member

Trott commented Jan 11, 2022

Oh, wait, no it won't. This is good. You probably want to run tools/update-authors.js (and then maybe trim off any new authors it adds at the end--probably best to leave that for a separate PR from the weekly job) to update your entry in AUTHORS. Or you can wait for the automated job to do that, I guess.

We can kick off the weekly/automated job manually, so let's land this.

@Trott Trott added the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 11, 2022
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Jan 11, 2022
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@Trott Trott added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Jan 11, 2022
@mhdawson @Trott
doc: update mailmap entries for mhdawson
02abe5c 
Update the content and order of my mailmap entries. Recent
changelogs have been using my outdated email address.

Signed-off-by: Michael Dawson <[email protected]>

PR-URL: nodejs#41437
Reviewed-By: Tierney Cyren <[email protected]>
Reviewed-By: Adrian Estrada <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Derek Lewis <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@Trott
Copy link
Member

Trott commented Jan 11, 2022

Landed in 02abe5c

@Trott Trott merged commit 02abe5c into nodejs:master Jan 11, 2022
targos pushed a commit that referenced this pull request Jan 14, 2022
@mhdawson @targos
doc: update mailmap entries for mhdawson
524103d 
Update the content and order of my mailmap entries. Recent
changelogs have been using my outdated email address.

Signed-off-by: Michael Dawson <[email protected]>

PR-URL: #41437
Reviewed-By: Tierney Cyren <[email protected]>
Reviewed-By: Adrian Estrada <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Derek Lewis <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@targos targos mentioned this pull request Jan 16, 2022
Merged
thedull pushed a commit to thedull/node that referenced this pull request Jan 18, 2022
@mhdawson @thedull
doc: update mailmap entries for mhdawson
0624bd7 
Update the content and order of my mailmap entries. Recent
changelogs have been using my outdated email address.

Signed-off-by: Michael Dawson <[email protected]>

PR-URL: nodejs#41437
Reviewed-By: Tierney Cyren <[email protected]>
Reviewed-By: Adrian Estrada <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Derek Lewis <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Linkgoron pushed a commit to Linkgoron/node that referenced this pull request Jan 31, 2022
@mhdawson @Linkgoron
doc: update mailmap entries for mhdawson
630ce85 
Update the content and order of my mailmap entries. Recent
changelogs have been using my outdated email address.

Signed-off-by: Michael Dawson <[email protected]>

PR-URL: nodejs#41437
Reviewed-By: Tierney Cyren <[email protected]>
Reviewed-By: Adrian Estrada <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Derek Lewis <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
danielleadams pushed a commit that referenced this pull request Feb 1, 2022
@mhdawson @danielleadams
doc: update mailmap entries for mhdawson
30cb694 
Update the content and order of my mailmap entries. Recent
changelogs have been using my outdated email address.

Signed-off-by: Michael Dawson <[email protected]>

PR-URL: #41437
Reviewed-By: Tierney Cyren <[email protected]>
Reviewed-By: Adrian Estrada <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Derek Lewis <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@danielleadams danielleadams mentioned this pull request Feb 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DerekNonGeneric DerekNonGeneric DerekNonGeneric approved these changes

@richardlau richardlau richardlau approved these changes

@edsadr edsadr edsadr approved these changes

@Trott Trott Trott approved these changes

@bnb bnb bnb approved these changes

Assignees
No one assigned
Labels
meta Issues and PRs related to the general management of the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@mhdawson @Trott @nodejs-github-bot @bnb @edsadr @richardlau @DerekNonGeneric