Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add reference for == and != operators #41413

Merged
merged 2 commits into from
Jan 8, 2022
Merged

doc: add reference for == and != operators #41413

merged 2 commits into from
Jan 8, 2022

Conversation

Trott
Copy link
Member

@Trott Trott commented Jan 5, 2022

@nodejs-github-bot nodejs-github-bot added assert Issues and PRs related to the assert subsystem. doc Issues and PRs related to the documentations. labels Jan 5, 2022
Trott
Trott commented Jan 5, 2022
View reviewed changes
doc/api/assert.md Outdated Show resolved Hide resolved
@Trott Trott added the commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. label Jan 5, 2022
tniessen
tniessen approved these changes Jan 6, 2022
View reviewed changes
Copy link
Member

@tniessen tniessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but be aware that strict mode still refers to the ES spec for the === operation, while the reference to the ES spec for the == operation was removed in the previous PR.

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 6, 2022
@Trott Trott added the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 8, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 8, 2022
@nodejs-github-bot nodejs-github-bot merged commit 1744836 into nodejs:master Jan 8, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in 1744836

@Trott Trott deleted the equality branch January 8, 2022 04:32
targos pushed a commit that referenced this pull request Jan 14, 2022
@Trott @targos
doc: add reference for == and != operators
f43bfe2 
Refs: #41375 (comment)

PR-URL: #41413
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
@targos targos mentioned this pull request Jan 16, 2022
Merged
thedull pushed a commit to thedull/node that referenced this pull request Jan 18, 2022
@Trott @thedull
doc: add reference for == and != operators
5d9fe91 
Refs: nodejs#41375 (comment)

PR-URL: nodejs#41413
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Linkgoron pushed a commit to Linkgoron/node that referenced this pull request Jan 31, 2022
@Trott @Linkgoron
doc: add reference for == and != operators
72fc56c 
Refs: nodejs#41375 (comment)

PR-URL: nodejs#41413
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
danielleadams pushed a commit that referenced this pull request Feb 1, 2022
@Trott @danielleadams
doc: add reference for == and != operators
b281bf5 
Refs: #41375 (comment)

PR-URL: #41413
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
@danielleadams danielleadams mentioned this pull request Feb 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VoltrexKeyva VoltrexKeyva VoltrexKeyva approved these changes

@tniessen tniessen tniessen approved these changes

@apapirovski apapirovski apapirovski approved these changes

Assignees
No one assigned
Labels
assert Issues and PRs related to the assert subsystem. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Trott @nodejs-github-bot @apapirovski @tniessen @VoltrexKeyva