Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: replace while+exec() with matchAll() #41406

Merged
merged 1 commit into from
Jan 9, 2022
Merged

tools: replace while+exec() with matchAll() #41406

merged 1 commit into from
Jan 9, 2022

Conversation

Trott
Copy link
Member

@Trott Trott commented Jan 5, 2022

No description provided.

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. tools Issues and PRs related to the tools directory. labels Jan 5, 2022
tniessen
tniessen approved these changes Jan 5, 2022
View reviewed changes
tools/doc/allhtml.mjs
Comment on lines 103 to 109
// Validate all hrefs have a target.
const ids = new Set();
const idRe = / id="([^"]+)"/g;
let match;
while (match = idRe.exec(all)) {
const idMatches = all.matchAll(idRe);
for (const match of idMatches) {
ids.add(match[1]);
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Optional suggestion to get rid of a few statements:

const ids = new Set([...all.matchAll(idRe)].map((match) => match[1]));

Or even:

const ids =
  new Set([...all.matchAll(/ id="([^"]+)"/g)].map((match) => match[1]));

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 6, 2022
@Trott Trott added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 8, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 8, 2022
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/41789/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/41792/

@github-actions github-actions bot mentioned this pull request Jan 9, 2022
Open
18 tasks
@Trott Trott added the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 9, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 9, 2022
@nodejs-github-bot nodejs-github-bot merged commit e247089 into nodejs:master Jan 9, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in e247089

@Trott Trott deleted the matchallall branch January 9, 2022 13:23
Trott added a commit to Trott/io.js that referenced this pull request Jan 9, 2022
@Trott @tniessen
tools: replace for loop with map()
39aaab2 
Refs: nodejs#41406 (comment)
Co-authored-by: Tobias Nießen <[email protected]>
@Trott Trott mentioned this pull request Jan 9, 2022
Merged
This was referenced Jan 12, 2022
Open
Open
Trott added a commit to Trott/io.js that referenced this pull request Jan 13, 2022
@Trott
tools: replace for loop with map()
500241d 
Refs: nodejs#41406 (comment)
Co-authored-by: Tobias Nießen <[email protected]>

PR-URL: nodejs#41451
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Anto Aravinth <[email protected]>
@github-actions github-actions bot mentioned this pull request Jan 14, 2022
Open
22 tasks
targos pushed a commit that referenced this pull request Jan 14, 2022
@Trott @targos
tools: replace while+exec() with matchAll()
4a57d47 
PR-URL: #41406
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
targos pushed a commit that referenced this pull request Jan 14, 2022
@Trott @targos
tools: replace for loop with map()
ec337b2 
Refs: #41406 (comment)
Co-authored-by: Tobias Nießen <[email protected]>

PR-URL: #41451
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Anto Aravinth <[email protected]>
@targos targos mentioned this pull request Jan 16, 2022
Merged
mawaregetsuka pushed a commit to mawaregetsuka/node that referenced this pull request Jan 17, 2022
@Trott @mawaregetsuka
tools: replace for loop with map()
1406726 
Refs: nodejs#41406 (comment)
Co-authored-by: Tobias Nießen <[email protected]>

PR-URL: nodejs#41451
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Anto Aravinth <[email protected]>
thedull pushed a commit to thedull/node that referenced this pull request Jan 18, 2022
@Trott @thedull
tools: replace while+exec() with matchAll()
d304be3 
PR-URL: nodejs#41406
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
thedull pushed a commit to thedull/node that referenced this pull request Jan 18, 2022
@Trott @thedull
tools: replace for loop with map()
c579369 
Refs: nodejs#41406 (comment)
Co-authored-by: Tobias Nießen <[email protected]>

PR-URL: nodejs#41451
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Anto Aravinth <[email protected]>
Linkgoron pushed a commit to Linkgoron/node that referenced this pull request Jan 31, 2022
@Trott @Linkgoron
tools: replace while+exec() with matchAll()
8c7d69d 
PR-URL: nodejs#41406
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Linkgoron pushed a commit to Linkgoron/node that referenced this pull request Jan 31, 2022
@Trott @Linkgoron
tools: replace for loop with map()
165c02f 
Refs: nodejs#41406 (comment)
Co-authored-by: Tobias Nießen <[email protected]>

PR-URL: nodejs#41451
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Anto Aravinth <[email protected]>
danielleadams pushed a commit that referenced this pull request Feb 1, 2022
@Trott @danielleadams
tools: replace while+exec() with matchAll()
62450d3 
PR-URL: #41406
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
danielleadams pushed a commit that referenced this pull request Feb 1, 2022
@Trott @danielleadams
tools: replace for loop with map()
86ece98 
Refs: #41406 (comment)
Co-authored-by: Tobias Nießen <[email protected]>

PR-URL: #41451
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Anto Aravinth <[email protected]>
@danielleadams danielleadams mentioned this pull request Feb 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tniessen tniessen tniessen approved these changes

@targos targos targos approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Trott @nodejs-github-bot @targos @tniessen