Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta: update AUTHORS #41144

Merged
merged 1 commit into from
Dec 12, 2021
Merged

meta: update AUTHORS #41144

merged 1 commit into from
Dec 12, 2021

Conversation

nodejs-github-bot
Copy link
Collaborator

Here are some new additions to the AUTHORS file. This is an automatically generated PR by the authors.yml GitHub Action, which runs tools/update-authors.js.

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Dec 12, 2021
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tierney's entry is a duplicate that needs a .mailmap entry addition instead.

Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready to land now.

@Trott Trott added the commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. label Dec 12, 2021
@Trott Trott added the fast-track PRs that do not need to wait for 48 hours to land. label Dec 12, 2021
@github-actions
Copy link
Contributor

Fast-track has been requested by @Trott. Please 👍 to approve.

@Trott Trott added the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 12, 2021
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Dec 12, 2021
@nodejs-github-bot
Copy link
Collaborator Author

Commit Queue failed
- Loading data for nodejs/node/pull/41144
✔  Done loading data for nodejs/node/pull/41144
----------------------------------- PR info ------------------------------------
Title      meta: update AUTHORS (#41144)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     nodejs-github-bot:actions/authors-update -> nodejs:master
Labels     meta, fast-track, commit-queue-squash
Commits    2
 - meta: update AUTHORS
 - fixup! meta: update AUTHORS
Committers 2
 - Node.js GitHub Bot 
 - Rich Trott 
PR-URL: https://github.com/nodejs/node/pull/41144
Reviewed-By: Rich Trott 
Reviewed-By: Luigi Pinca 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/41144
Reviewed-By: Rich Trott 
Reviewed-By: Luigi Pinca 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Sun, 12 Dec 2021 00:16:11 GMT
   ✔  Approvals: 2
   ✔  - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/41144#pullrequestreview-829579644
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/41144#pullrequestreview-829660067
   ℹ  This PR is being fast-tracked
   ✖  GitHub CI is still running
   ℹ  Green GitHub Actions CI is sufficient
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/1570247089

PR-URL: #41144
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@Trott Trott force-pushed the actions/authors-update branch from 2df2823 to 4d7dd6c Compare December 12, 2021 23:49
@Trott
Copy link
Member

Trott commented Dec 12, 2021

Landed in 4d7dd6c

@Trott Trott merged commit 4d7dd6c into master Dec 12, 2021
@Trott Trott deleted the actions/authors-update branch December 12, 2021 23:50
danielleadams pushed a commit that referenced this pull request Dec 13, 2021
PR-URL: #41144
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
danielleadams pushed a commit that referenced this pull request Dec 14, 2021
PR-URL: #41144
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 31, 2022
PR-URL: #41144
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 31, 2022
PR-URL: #41144
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Linkgoron pushed a commit to Linkgoron/node that referenced this pull request Jan 31, 2022
PR-URL: nodejs#41144
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
danielleadams pushed a commit that referenced this pull request Feb 1, 2022
PR-URL: #41144
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@danielleadams danielleadams mentioned this pull request Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
commit-queue-failed An error occurred while landing this pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. fast-track PRs that do not need to wait for 48 hours to land. meta Issues and PRs related to the general management of the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants