-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: fix flaky test-net-socket-local-address #4109
Conversation
test-net-socket-local-address had a race condition that resulted in unreliability on FreeBSD and Windows. This changes fixes the issue. Fixes: nodejs#2475
FreeBSD stress test with this fix: Windows stress test with this fix: Standard CI test for this PR: |
Ugh, hard fail on Windows, back to the drawing board... |
Small tweak hopefully fixes it. FreeBSD stress: https://ci.nodejs.org/job/node-stress-single-test/125/nodes=freebsd102-64/console Windows stress: https://ci.nodejs.org/job/node-stress-single-test/124/nodes=win2012r2/console Standard CI: https://ci.nodejs.org/job/node-test-pull-request/898/ Come on, Windows, don't be cruel to me again... |
FreeBSD mega-failures on CI look mega-unrelated and probably some process cleanup on the CI infrastructure that didn't happen or something like that. Re-running just FreeBSD here: https://ci.nodejs.org/job/node-test-commit-freebsd/nodes=freebsd102-64/473/console |
CI looks clean (with the FreeBSD re-run and allowing for known flaky tests on Windows for which there are pending PRs to fix, woot). Stress tests are both looking great. FreeBSD ran 9999 times without a problem. Windows is up over 4000 runs as of this writing without a problem. Assuming no surprises on Windows between here and run number 9999, that brings us to:
|
LGTM |
@Trott Sure, LGTM. |
LGTM |
test-net-socket-local-address had a race condition that resulted in unreliability on FreeBSD and Windows. This changes fixes the issue. Fixes: #2475 PR-URL: #4109 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Johan Bergström <[email protected]>
Landed in c79b145 |
test-net-socket-local-address had a race condition that resulted in unreliability on FreeBSD and Windows. This changes fixes the issue. Fixes: #2475 PR-URL: #4109 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Johan Bergström <[email protected]>
test-net-socket-local-address had a race condition that resulted in unreliability on FreeBSD and Windows. This changes fixes the issue. Fixes: #2475 PR-URL: #4109 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Johan Bergström <[email protected]>
test-net-socket-local-address had a race condition that resulted in unreliability on FreeBSD and Windows. This changes fixes the issue. Fixes: #2475 PR-URL: #4109 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Johan Bergström <[email protected]>
test-net-socket-local-address had a race condition that resulted in unreliability on FreeBSD and Windows. This changes fixes the issue. Fixes: nodejs#2475 PR-URL: nodejs#4109 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Johan Bergström <[email protected]>
test-net-socket-local-address had a race condition that resulted in
unreliability on FreeBSD and Windows. This changes fixes the issue.
Fixes: #2475