Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: remove extraneous quotation marks from commit body #40963

Merged
merged 1 commit into from
Nov 25, 2021
Merged

build: remove extraneous quotation marks from commit body #40963

merged 1 commit into from
Nov 25, 2021

Conversation

Trott
Copy link
Member

@Trott Trott commented Nov 25, 2021

@Trott Trott added the fast-track PRs that do not need to wait for 48 hours to land. label Nov 25, 2021
@Trott Trott requested a review from aduh95 November 25, 2021 01:11
@github-actions
Copy link
Contributor

Fast-track has been requested by @Trott. Please 👍 to approve.

@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Nov 25, 2021
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Nov 25, 2021
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 25, 2021
@nodejs-github-bot nodejs-github-bot merged commit 78cc2bd into nodejs:master Nov 25, 2021
@nodejs-github-bot
Copy link
Collaborator

Landed in 78cc2bd

@aduh95
Copy link
Contributor

aduh95 commented Nov 25, 2021

Seems to have worked just fine 👌

Run gr2m/create-or-update-pull-request-action@v1
  with:
    author: Node.js GitHub Bot <[email protected]>
    branch: actions/inactive-tsc
    body: This PR was generated by tools/find-inactive-tsc.yml.
  
  @nodejs/tsc @codebytere @gabrielschulhof
  
  Since 3 months ago, codebytere attended 0 out of 10 meetings and voted in 0 of 2 votes. Since 3 months ago, gabrielschulhof attended 0 out of 10 meetings and voted in 0 of 2 votes.
  
    commit-message: meta: move one or more TSC members to emeritus
    labels: meta
    title: meta: move one or more TSC members to emeritus

targos pushed a commit that referenced this pull request Nov 26, 2021
@Trott @targos
build: remove extraneous quotation marks from commit body
65b33ba 
Refs: #40915 (comment)

PR-URL: #40963
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
@targos targos mentioned this pull request Nov 26, 2021
Merged
danielleadams pushed a commit that referenced this pull request Jan 30, 2022
@Trott @danielleadams
build: remove extraneous quotation marks from commit body
39c233f 
Refs: #40915 (comment)

PR-URL: #40963
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
danielleadams pushed a commit that referenced this pull request Feb 1, 2022
@Trott @danielleadams
build: remove extraneous quotation marks from commit body
a905dfe 
Refs: #40915 (comment)

PR-URL: #40963
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
@danielleadams danielleadams mentioned this pull request Feb 1, 2022
Merged
@Trott Trott deleted the quotes branch September 25, 2022 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VoltrexKeyva VoltrexKeyva VoltrexKeyva approved these changes

@aduh95 aduh95 aduh95 approved these changes

@targos targos targos approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Trott @nodejs-github-bot @aduh95 @targos @VoltrexKeyva