make -J behavior default in test.py #40945
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
build
github-actions
bot
removed
the
request-ci
aduh95
approved these changes
Nov 24, 2021
richardlau
reviewed
Nov 24, 2021
| @@ -1423,7 +1423,7 @@ def ProcessOptions(options): | |||
| if options.run[0] >= options.run[1]: | |||
| print("The test group to run (n) must be smaller than number of groups (m).") | |||
| return False | |||
| if options.J: | |||
| if options.j == 0: | |||
There was a problem hiding this comment.
This changes precedence of the -j and -J flags, e.g. if test.py -j 3 -J was run and JOBS=2 then the old code would have overwritten the j value from JOBS but the new code would leave j unchanged.
It's probably a rare edge case that both flags would be specified.
There was a problem hiding this comment.
If we keep it so -J effectively negates -j, we'll have to update the help text to indicate that -J doesn't quite have no effect at all.
If we want to preserve that behavior, then perhaps the thing to do is print a warning when someone is using both -J and -j? Or maybe print a warning every time -J is used?
I suspect, like you, that this is a rare edge case. I also suspect that it basically does not matter. Like, if we run with 2 processes instead of 4 (or the other way around) in a rare edge case....oh well?
@richardlau Would you be comfortable if we kept the behavior as it is in this PR but add a warning that gets printed if both -j and -J are specified?
There was a problem hiding this comment.
@richardlau Would you be comfortable if we kept the behavior as it is in this PR but add a warning that gets printed if both
-jand-Jare specified?
This is the behavior I've implemented in a fixup commit. PTAL.
38 tasks
lpinca
approved these changes
Nov 25, 2021
richardlau
reviewed
Nov 25, 2021
richardlau
approved these changes
Nov 25, 2021
33 tasks
github-actions
bot
removed
the
request-ci
27 tasks
Trott
added
commit-queue-rebase
nodejs-github-bot
removed
the
commit-queue
|
Landed in e64c66c...a257294 |
nodejs-github-bot
pushed a commit
that referenced
this pull request
Nov 27, 2021
PR-URL: #40945 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Richard Lau <[email protected]>
nodejs-github-bot
pushed a commit
that referenced
this pull request
Nov 27, 2021
PR-URL: #40945 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Richard Lau <[email protected]>
nodejs-github-bot
pushed a commit
that referenced
this pull request
Nov 27, 2021
PR-URL: #40945 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Richard Lau <[email protected]>
This was referenced Nov 28, 2021
danielleadams
pushed a commit
that referenced
this pull request
Dec 13, 2021
PR-URL: #40945 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Richard Lau <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Dec 13, 2021
PR-URL: #40945 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Richard Lau <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Dec 13, 2021
PR-URL: #40945 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Richard Lau <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Dec 14, 2021
PR-URL: #40945 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Richard Lau <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Dec 14, 2021
PR-URL: #40945 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Richard Lau <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Dec 14, 2021
PR-URL: #40945 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Richard Lau <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Jan 30, 2022
PR-URL: #40945 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Richard Lau <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Jan 30, 2022
PR-URL: #40945 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Richard Lau <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Jan 30, 2022
PR-URL: #40945 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Richard Lau <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Feb 1, 2022
PR-URL: #40945 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Richard Lau <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Feb 1, 2022
PR-URL: #40945 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Richard Lau <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Feb 1, 2022
PR-URL: #40945 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Richard Lau <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.