doc: clarify more optional parameters in node-api #40888
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refs: nodejs/abi-stable-node#252 Signed-off-by: Michael Dawson <[email protected]>
nodejs-github-bot
added
doc
|
Working my way through the node-api looking for instances where optional parameters are not documented. |
jasnell
approved these changes
Nov 20, 2021
lpinca
approved these changes
Nov 20, 2021
tniessen
approved these changes
Nov 21, 2021
mhdawson
added a commit
that referenced
this pull request
Nov 22, 2021
Refs: nodejs/abi-stable-node#252 Signed-off-by: Michael Dawson <[email protected]> PR-URL: #40888 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
|
Landed in 0b4d066 |
targos
pushed a commit
that referenced
this pull request
Nov 26, 2021
Refs: nodejs/abi-stable-node#252 Signed-off-by: Michael Dawson <[email protected]> PR-URL: #40888 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Jan 30, 2022
Refs: nodejs/abi-stable-node#252 Signed-off-by: Michael Dawson <[email protected]> PR-URL: #40888 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Feb 1, 2022
Refs: nodejs/abi-stable-node#252 Signed-off-by: Michael Dawson <[email protected]> PR-URL: #40888 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: nodejs/abi-stable-node#252
Signed-off-by: Michael Dawson [email protected]