Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

meta: update name and email #40848

Closed
wants to merge 1 commit into from
Closed

meta: update name and email #40848

wants to merge 1 commit into from

Conversation

null8626
Copy link
Contributor

  • changed my name in AUTHORS to use my real name
  • changed my email in AUTHORS to my main gmail account
  • changed @VoltrexMaster's name to show his real name (updated in AUTHORS and README.md)

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project. labels Nov 18, 2021
@Trott
Copy link
Member

Trott commented Nov 18, 2021 •
edited
Loading

The AUTHORS file is automatically generated. Edits made directly to it will be overwritten. You need to instead add an entry in .mailmap.

As for @VoltrexMaster's name, if they want it changed, they'll change it themselves.

@VoltrexKeyva
Copy link
Member

VoltrexKeyva commented Nov 18, 2021 •
edited
Loading

@Trott I approve of the name change, it's alright for them to change it, I was going to change it either way. 😄

@Trott Trott mentioned this pull request Nov 18, 2021
Closed
@Trott
Copy link
Member

Trott commented Nov 18, 2021

@vierofernando Take a look at #40850 to see the necessary changes to .mailmap to make sure these changes don't get undone by an automated weekly process. Feel free to copy those changes into this PR, in which case I'll close that one. (Or if you'd rather just close this one and let that one land, that's fine too. Either way!)

@Trott Trott added the fast-track PRs that do not need to wait for 48 hours to land. label Nov 18, 2021
@github-actions
Copy link
Contributor

Fast-track has been requested by @Trott. Please 👍 to approve.

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 18, 2021
Trott
Trott requested changes Nov 18, 2021
View reviewed changes
.mailmap Outdated Show resolved Hide resolved
@Trott Trott removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 18, 2021
@Trott Trott self-requested a review November 18, 2021 17:51
@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 18, 2021
@null8626 @Trott
meta: update name and email
8a09a1e 
PR-URL: #40848
Reviewed-By: Voltrex <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@Trott
Copy link
Member

Trott commented Nov 18, 2021

Landed in 8a09a1e

@Trott Trott closed this Nov 18, 2021
targos pushed a commit that referenced this pull request Nov 21, 2021
@null8626 @targos
meta: update name and email
dfc6fc9 
PR-URL: #40848
Reviewed-By: Voltrex <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@targos targos mentioned this pull request Nov 26, 2021
Merged
danielleadams pushed a commit that referenced this pull request Jan 30, 2022
@null8626 @danielleadams
meta: update name and email
79eda1b 
PR-URL: #40848
Reviewed-By: Voltrex <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
danielleadams pushed a commit that referenced this pull request Feb 1, 2022
@null8626 @danielleadams
meta: update name and email
317cd3f 
PR-URL: #40848
Reviewed-By: Voltrex <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@danielleadams danielleadams mentioned this pull request Feb 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VoltrexKeyva VoltrexKeyva VoltrexKeyva approved these changes

@Trott Trott Trott approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. meta Issues and PRs related to the general management of the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@null8626 @Trott @VoltrexKeyva @nodejs-github-bot