tools: fix commit-lint GH Actions CI #40845
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
meta
jasnell
approved these changes
Nov 20, 2021
aduh95
added
the
author ready
jasnell
pushed a commit
that referenced
this pull request
Nov 25, 2021
PR-URL: #40845 Reviewed-By: James M Snell <[email protected]>
|
Landed in 27b1088 |
targos
pushed a commit
that referenced
this pull request
Nov 26, 2021
PR-URL: #40845 Reviewed-By: James M Snell <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Jan 30, 2022
PR-URL: #40845 Reviewed-By: James M Snell <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Feb 1, 2022
PR-URL: #40845 Reviewed-By: James M Snell <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #40740, I tried to make a change to the
commit-lintjob for it to lint only one commit per PR. However, because I'm clearly lacking some git expertise, I did it completely wrong: instead of validating the first commit of the PR, it's now validating the.. last commit that landed onmasterbefore the CI starts. This PR aims to fix that.I'm doing
git reset HEAD^2to land to the last commit in the PR, there might be a more elegant way to target the commit we're after without doing agit reset, but also it's not a very expensive operation so it may be just fine.