Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stream: pipeline should drain empty readable #40654

Closed
wants to merge 1 commit into from
Closed

stream: pipeline should drain empty readable #40654

wants to merge 1 commit into from

Conversation

ronag
Copy link
Member

@ronag ronag commented Oct 29, 2021 •
edited
Loading

This simplifies some cases where the last stream is a Duplex
without any expected output.

await pipeline(readable, duplex)

Related: #40653

@ronag ronag added the stream Issues and PRs related to the stream subsystem. label Oct 29, 2021
@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Oct 29, 2021
@ronag
Copy link
Member Author

ronag commented Oct 29, 2021

@nodejs/streams

@ronag ronag force-pushed the drain-empty-readable branch from 9e5a829 to 8d15eb2 Compare October 29, 2021 11:25
@ronag ronag requested a review from mcollina October 29, 2021 11:25
@ronag ronag added the semver-major PRs that contain breaking changes and should be released in the next major version. label Oct 29, 2021
mcollina
mcollina approved these changes Oct 29, 2021
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ronag ronag added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. and removed needs-ci PRs that need a full CI run. labels Oct 31, 2021
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 31, 2021
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40589/

This was referenced Nov 1, 2021
Open
Open
Open
@ronag ronag requested a review from jasnell November 4, 2021 20:53
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40714/

@github-actions github-actions bot mentioned this pull request Nov 5, 2021
Open
43 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40729/

mcollina
mcollina approved these changes Nov 5, 2021
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ronag
Copy link
Member Author

ronag commented Nov 5, 2021

CITGM: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/2789/

This was referenced Nov 6, 2021
Open
Open
Open
Open
Open
@ronag ronag requested a review from lpinca November 10, 2021 15:23
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40821/

@github-actions github-actions bot mentioned this pull request Nov 12, 2021
Open
35 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40846/

@github-actions github-actions bot mentioned this pull request Nov 13, 2021
Open
31 tasks
@ronag
Copy link
Member Author

ronag commented Nov 13, 2021

@nodejs/tsc this needs another TSC approval

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40863/

@github-actions github-actions bot mentioned this pull request Nov 14, 2021
Open
41 tasks
@Trott
Copy link
Member

Trott commented Nov 14, 2021

This needs a rebase against the master branch for one of the tests to pass on the Pi devices.

@ronag
stream: pipeline should drain empty readable
181bdf9 
This simplifies some cases where the last stream is a Duplex
without any expected output.

await pipeline(readable, duplex)
@ronag ronag force-pushed the drain-empty-readable branch from 8d15eb2 to 181bdf9 Compare November 14, 2021 13:51
@ronag ronag added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 14, 2021
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 14, 2021
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40881/

@github-actions github-actions bot mentioned this pull request Nov 15, 2021
Open
44 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40898/

@github-actions github-actions bot mentioned this pull request Nov 16, 2021
Open
40 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40923/

This was referenced Nov 17, 2021
Open
Open
@ronag ronag removed the semver-major PRs that contain breaking changes and should be released in the next major version. label Nov 18, 2021
@ronag
Copy link
Member Author

ronag commented Nov 18, 2021

@mcollina I don't think this should be semver-major. wdyt?

mcollina
mcollina approved these changes Nov 18, 2021
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, ok

@ronag
Copy link
Member Author

ronag commented Nov 18, 2021

Landed in 0a3a601

@ronag ronag closed this Nov 18, 2021
ronag added a commit that referenced this pull request Nov 18, 2021
@ronag
stream: pipeline should drain empty readable
0a3a601 
This simplifies some cases where the last stream is a Duplex
without any expected output.

await pipeline(readable, duplex)

PR-URL: #40654
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@github-actions github-actions bot mentioned this pull request Nov 19, 2021
Open
31 tasks
targos pushed a commit that referenced this pull request Nov 21, 2021
@ronag @targos
stream: pipeline should drain empty readable
16ee842 
This simplifies some cases where the last stream is a Duplex
without any expected output.

await pipeline(readable, duplex)

PR-URL: #40654
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@targos targos mentioned this pull request Nov 26, 2021
Merged
danielleadams pushed a commit that referenced this pull request Jan 30, 2022
@ronag @danielleadams
stream: pipeline should drain empty readable
644b9a9 
This simplifies some cases where the last stream is a Duplex
without any expected output.

await pipeline(readable, duplex)

PR-URL: #40654
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
danielleadams pushed a commit that referenced this pull request Feb 1, 2022
@ronag @danielleadams
stream: pipeline should drain empty readable
c9f1398 
This simplifies some cases where the last stream is a Duplex
without any expected output.

await pipeline(readable, duplex)

PR-URL: #40654
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@danielleadams danielleadams mentioned this pull request Feb 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@benjamingr benjamingr benjamingr approved these changes

@mcollina mcollina mcollina approved these changes

@jasnell jasnell Awaiting requested review from jasnell

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. stream Issues and PRs related to the stream subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ronag @nodejs-github-bot @Trott @mcollina @benjamingr @lpinca