src: fix #endif description in crypto_keygen.h #40639
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
|
Fast-track has been requested by @tniessen. Please 👍 to approve. |
bury9555
approved these changes
Oct 27, 2021
richardlau
approved these changes
Oct 27, 2021
cjihrig
approved these changes
Oct 28, 2021
VoltrexKeyva
approved these changes
Oct 28, 2021
jasnell
approved these changes
Oct 28, 2021
jasnell
added
the
commit-queue
github-actions
bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/40639 ✔ Done loading data for nodejs/node/pull/40639 ----------------------------------- PR info ------------------------------------ Title src: fix #endif description in crypto_keygen.h (#40639) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch tniessen:src-fix-endif-description-crypto-keygen -> nodejs:master Labels crypto, c++, fast-track Commits 1 - src: fix #endif description in crypto_keygen.h Committers 1 - Tobias Nießen PR-URL: https://github.com/nodejs/node/pull/40639 Reviewed-By: Richard Lau Reviewed-By: Colin Ihrig Reviewed-By: Voltrex Reviewed-By: James M Snell ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/40639 Reviewed-By: Richard Lau Reviewed-By: Colin Ihrig Reviewed-By: Voltrex Reviewed-By: James M Snell -------------------------------------------------------------------------------- ℹ This PR was created on Wed, 27 Oct 2021 22:35:52 GMT ✔ Approvals: 4 ✔ - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/40639#pullrequestreview-791257072 ✔ - Colin Ihrig (@cjihrig) (TSC): https://github.com/nodejs/node/pull/40639#pullrequestreview-791286828 ✔ - Voltrex (@VoltrexMaster): https://github.com/nodejs/node/pull/40639#pullrequestreview-791314930 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/40639#pullrequestreview-791939002 ℹ This PR is being fast-tracked ✔ Last GitHub Actions successful ✖ No Jenkins CI runs detected -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/1395031492 |
VoltrexKeyva
pushed a commit
that referenced
this pull request
Oct 28, 2021
PR-URL: #40639 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Voltrex <[email protected]> Reviewed-By: James M Snell <[email protected]>
|
Landed in f3125cf |
targos
pushed a commit
that referenced
this pull request
Nov 6, 2021
PR-URL: #40639 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Voltrex <[email protected]> Reviewed-By: James M Snell <[email protected]>
BethGriggs
pushed a commit
that referenced
this pull request
Nov 25, 2021
PR-URL: #40639 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Voltrex <[email protected]> Reviewed-By: James M Snell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be the same as the condition at the beginning of the file.