Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta: consolidate AUTHORS entries for alexzherdev #40620

Closed
wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Oct 27, 2021

No description provided.

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Oct 27, 2021
@Trott
Copy link
Member Author

Trott commented Oct 27, 2021

@alexzherdev This uses a .mailmap entry to remove your acl.com email from AUTHORS and leave your gmail.com address. If you'd prefer we do something else, please comment. Thanks!

@Trott Trott added the fast-track PRs that do not need to wait for 48 hours to land. label Oct 27, 2021
@github-actions
Copy link
Contributor

Fast-track has been requested by @Trott. Please 👍 to approve.

@alexzherdev
Copy link
Contributor

@Trott The acl.com address doesn't belong to me anymore. Could we remove it altogether? Thanks!

@Trott
Copy link
Member Author

Trott commented Oct 27, 2021

@Trott The acl.com address doesn't belong to me anymore. Could we remove it altogether? Thanks!

Yes, that's what this basically does. The .mailmap entry says "if you see this acl.com address, use this gmail.com address instead."

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 27, 2021
@jasnell jasnell added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 28, 2021
@github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 28, 2021
@github-actions
Copy link
Contributor

Landed in 3a74481...1306d5c

@github-actions github-actions bot closed this Oct 28, 2021
nodejs-github-bot pushed a commit that referenced this pull request Oct 28, 2021
PR-URL: #40620
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
targos pushed a commit that referenced this pull request Nov 6, 2021

Verified

This commit was signed with the committer’s verified signature.
targos Michaël Zasso
PR-URL: #40620
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@targos targos mentioned this pull request Nov 8, 2021
BethGriggs pushed a commit that referenced this pull request Nov 25, 2021

Verified

This commit was signed with the committer’s verified signature.
BethGriggs Bethany Griggs
PR-URL: #40620
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@BethGriggs BethGriggs mentioned this pull request Nov 26, 2021
1 task
@Trott Trott deleted the authors-az branch September 25, 2022 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. meta Issues and PRs related to the general management of the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants