deps,build,tools: fix openssl-is-fips for ninja builds #40518
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently using the --openssl-is-fips configuration option in combination with --ninja is broken. This commit fixes two issues, one being an issue with the linker/version script path variable. The second is that the locations of built artifacts that differ for ninja and make. ninja: $ ./configure --openssl-is-fips --ninja $ ninja -C out/Release $ ./node --enable-fips -p 'crypto.getFips()' 1 make: $ ./configure --openssl-is-fips $ make -j8 $ ./node --enable-fips -p 'crypto.getFips()' 1 Refs: nodejs#40509
nodejs-github-bot
added
build
|
Note that this fixes the path issue seen in #40421, but the macro-redefined warning is still emitted: |
27 tasks
richardlau
approved these changes
Oct 20, 2021
BethGriggs
approved these changes
Oct 20, 2021
danbev
added
the
author ready
|
non-contributor +1, running into this trying to build Node.js in a Docker image :) |
30 tasks
danbev
added a commit
that referenced
this pull request
Oct 21, 2021
Currently using the --openssl-is-fips configuration option in combination with --ninja is broken. This commit fixes two issues, one being an issue with the linker/version script path variable. The second is that the locations of built artifacts that differ for ninja and make. ninja: $ ./configure --openssl-is-fips --ninja $ ninja -C out/Release $ ./node --enable-fips -p 'crypto.getFips()' 1 make: $ ./configure --openssl-is-fips $ make -j8 $ ./node --enable-fips -p 'crypto.getFips()' 1 PR-URL: #40518 Refs: #40509 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Beth Griggs <[email protected]>
danbev
added a commit
that referenced
this pull request
Oct 21, 2021
PR-URL: #40518 Refs: #40509 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Beth Griggs <[email protected]>
danbev
added a commit
that referenced
this pull request
Oct 21, 2021
PR-URL: #40518 Refs: #40509 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Beth Griggs <[email protected]>
This was referenced Oct 22, 2021
targos
pushed a commit
that referenced
this pull request
Oct 23, 2021
Currently using the --openssl-is-fips configuration option in combination with --ninja is broken. This commit fixes two issues, one being an issue with the linker/version script path variable. The second is that the locations of built artifacts that differ for ninja and make. ninja: $ ./configure --openssl-is-fips --ninja $ ninja -C out/Release $ ./node --enable-fips -p 'crypto.getFips()' 1 make: $ ./configure --openssl-is-fips $ make -j8 $ ./node --enable-fips -p 'crypto.getFips()' 1 PR-URL: #40518 Refs: #40509 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Beth Griggs <[email protected]>
targos
pushed a commit
that referenced
this pull request
Oct 23, 2021
PR-URL: #40518 Refs: #40509 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Beth Griggs <[email protected]>
targos
pushed a commit
that referenced
this pull request
Oct 23, 2021
PR-URL: #40518 Refs: #40509 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Beth Griggs <[email protected]>
This was referenced Oct 24, 2021
gengjiawen
reviewed
Dec 29, 2021
| 'out', default_variables['build_type'])) | ||
| else: | ||
| default_variables.setdefault("PRODUCT_DIR_ABS", os.path.join(output_dir, | ||
| default_variables['build_type'])) |
There was a problem hiding this comment.
@danbev should this sticks to CONFIGURATION_NAME, I run into some problems when directly run this files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently using the
--openssl-is-fipsconfiguration option incombination with
--ninjais broken.This commit fixes two issues, one being an issue with the linker/version
script path variable. The second is that the locations of built
artifacts that differ for ninja and make.
ninja:
make:
Refs: #40509